feat: add support to networkRules on authzPolicy

[victorsantos-cit]

Hello Folks, this PR is to add a support to networkRules field on google_network_security_authz_policy resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `network_rules` field on `google_network_security_authz_policy` resource

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a0e0336:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 5997 insertions(+), 1422 deletions(-)
google-beta provider	View Diff	4 files changed, 6165 insertions(+), 1422 deletions(-)
terraform-google-conversion	View Diff	4 files changed, 5747 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  network_rules {
    from {
      not_sources {
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains    = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          suffix = # value needed
        }
        resources {
          iam_service_account {
            contains    = # value needed
            exact       = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          tag_value_id_set {
            ids = # value needed
          }
        }
      }
      sources {
        ip_blocks {
          length = # value needed
          prefix = # value needed
        }
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains    = # value needed
            exact       = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          principal_selector = # value needed
          suffix             = # value needed
        }
        resources {
          iam_service_account {
            contains    = # value needed
            exact       = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          tag_value_id_set {
            ids = # value needed
          }
        }
      }
    }
    to {
      not_operations {
        header_set {
          headers {
            name = # value needed
            value {
              contains    = # value needed
              exact       = # value needed
              ignore_case = # value needed
              prefix      = # value needed
              suffix      = # value needed
            }
          }
        }
        hosts {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
        methods = # value needed
        paths {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
      operations {
        header_set {
          headers {
            name = # value needed
            value {
              contains    = # value needed
              exact       = # value needed
              ignore_case = # value needed
              prefix      = # value needed
              suffix      = # value needed
            }
          }
        }
        hosts {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
        mcp {
          base_protocol_methods_option = # value needed
          methods {
            name = # value needed
            params {
              contains    = # value needed
              exact       = # value needed
              ignore_case = # value needed
              prefix      = # value needed
              suffix      = # value needed
            }
          }
        }
        methods = # value needed
        paths {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
        snis {
          contains    = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
    }
    when = # value needed
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
83	75	7	1

Affected Service Packages

• networksecurity

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@victorsantos-cit, @BBBmau VCR tests complete for a0e0336!

[BBBmau]

we get the following error currently:

Error recording tests:
error running go: exit status 1
stdout:
=== RUN   TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample
=== PAUSE TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample
=== CONT  TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample
    resource_network_security_authz_policy_generated_test.go:433: Step 1/3 error: Error running apply: exit status 1
        
        Error: Error waiting to create AuthzPolicy: Error waiting for Creating AuthzPolicy: Error code 13, message: an internal error has occurred
        
          with google_network_security_authz_policy.default,
          on terraform_plugin_test.tf line 80, in resource "google_network_security_authz_policy" "default":
          80: resource "google_network_security_authz_policy" "default" {
        
--- FAIL: TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample (172.11s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/networksecurity	172.189s
FAIL
stderr:

also we should be extensive with networkRules since it contains a massive amount of new fields

[victorsantos-cit]

@BBBmau do you have any kind of ideia , about this error, because, local is working

[victorsantos-cit]

@BBBmau Hey bbb, just update you, this feature, its prevent to rollout on this final weekend but broken, in on contact tto discovery more update

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1c16a9d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 4691 insertions(+), 1838 deletions(-)
google-beta provider	View Diff	4 files changed, 4859 insertions(+), 1838 deletions(-)
terraform-google-conversion	View Diff	4 files changed, 3533 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  network_rules {
    from {
      not_sources {
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains    = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          suffix = # value needed
        }
        resources {
          iam_service_account {
            contains    = # value needed
            exact       = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          tag_value_id_set {
            ids = # value needed
          }
        }
      }
      sources {
        ip_blocks {
          length = # value needed
          prefix = # value needed
        }
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains    = # value needed
            exact       = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          principal_selector = # value needed
          suffix             = # value needed
        }
        resources {
          iam_service_account {
            contains    = # value needed
            exact       = # value needed
            ignore_case = # value needed
            prefix      = # value needed
            suffix      = # value needed
          }
          tag_value_id_set {
            ids = # value needed
          }
        }
      }
    }
    to {
      not_operations {
        ports = # value needed
        snis {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
      operations {
        ports = # value needed
        snis {
          contains    = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
    }
    when = # value needed
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
83	75	7	1

Affected Service Packages

• networksecurity

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@victorsantos-cit, @BBBmau VCR tests complete for 1c16a9d!