Add TensorboardExperiment resource#17781
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6242ed9: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_tensorboard_experiment" "primary" {
source = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @slevenick VCR tests complete for 6242ed9! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 495dad9: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @slevenick, @NickElliot VCR tests complete for 495dad9! |
|
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
NickElliot
left a comment
There was a problem hiding this comment.
thanks for implementing it with the location!
Using location rather than region per hashicorp/terraform-provider-google#27571
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.