Skip to content

Add TensorboardExperiment resource#17781

Open
slevenick wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
slevenick:tensorboard-experiment
Open

Add TensorboardExperiment resource#17781
slevenick wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
slevenick:tensorboard-experiment

Conversation

@slevenick
Copy link
Copy Markdown
Contributor

@slevenick slevenick commented Jun 1, 2026

Using location rather than region per hashicorp/terraform-provider-google#27571

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_vertex_ai_tensorboard_experiment`

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 1, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6242ed9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1204 insertions(+)
google-beta provider View Diff 4 files changed, 1204 insertions(+)
terraform-google-conversion View Diff 1 file changed, 162 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 232 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_tensorboard_experiment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_tensorboard_experiment" "primary" {
  source = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_tensorboard_experiment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
96 91 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAITensorboardExperiment_vertexAiTensorboardExperimentExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAITensorboardExperiment_vertexAiTensorboardExperimentExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 6242ed9!

@slevenick slevenick requested a review from NickElliot June 1, 2026 19:50
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 1, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 495dad9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1207 insertions(+)
google-beta provider View Diff 4 files changed, 1207 insertions(+)
terraform-google-conversion View Diff 1 file changed, 162 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 234 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_tensorboard_experiment

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
96 91 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAITensorboardExperiment_vertexAiTensorboardExperimentExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAITensorboardExperiment_vertexAiTensorboardExperimentExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick, @NickElliot VCR tests complete for 495dad9!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing it with the location!

@NickElliot NickElliot self-requested a review June 4, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants