fix: support v-prefixed connector versions and remove slf4j-nop profile - #4952
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the 'connector' Maven profile and the Cloud Build release pipeline configuration, adds '-Dslf4j.internal.verbosity=ERROR' to the startup scripts to suppress verbose logging, and updates the installer scripts to support version tags with an optional 'v' prefix. Feedback was provided on 'install.sh' to retain the cleanup of 'pgadapter.jsa' and 'install_path.txt' to avoid leaving large orphaned files on user upgrades.
…erPGConnectorShutdownTest
| Process connector = startConnector(tool.getAbsolutePath()); | ||
| try { | ||
| String clientPid = awaitContents(pidFile); | ||
| Thread.sleep(200L); |
There was a problem hiding this comment.
Never use Thread.sleep(..) in tests, at least not as a method to 'wait until something has happened'. It always comes with a risk that the test becomes flaky, and there is (almost) always some other way that you can achieve the same (e.g. by doing a busy wait and check for a specific condition, or by using some form of deterministic synchronization between threads).
There was a problem hiding this comment.
noted, merging this for now
d87e0bc
into
GoogleCloudPlatform:postgresql-dialect
2 participants
-Dslf4j.internal.verbosity=ERRORin the launcher scripts (spanner-pg-connector,spanner-pg-connector.cmd) and remove theconnectorMaven profile (slf4j-nop) frompom.xml.install.shandinstall.ps1to accept optionalv-prefixed release versions (vX.Y.Z) when resolving the latest package from Artifact Registry.spanner-pg-connector/cloudbuild.yaml. release builds and verification are managed by the louhi release pipeline.