Skip to content

adding RTL binding feature - #248

Open
Fahad-Alsaidi wants to merge 50 commits into
masterfrom
rtlBinding
Open

adding RTL binding feature #248
Fahad-Alsaidi wants to merge 50 commits into
masterfrom
rtlBinding

Conversation

@Fahad-Alsaidi

@Fahad-Alsaidi Fahad-Alsaidi commented Jun 8, 2025

Copy link
Copy Markdown
Contributor

This to review by scribus team.
@aoloe for kind review

Introduce support for right-to-left (RTL) binding in the Page Palette. This includes adjustments to page offsets, rendering logic, and group positioning to accurately handle RTL page layouts. A new function `set_rtl_binding` tracks the binding direction, ensuring proper visual representation.
there are some bugs but I will fix them later.
Ensure correct column index adjustment when right-to-left binding is enabled. This resolves potential issues in layout rendering for RTL documents.
This commit removes all code related to the 'binding' feature in the page layout widget, including member variables, methods, UI components, and related logic. This cleanup simplifies the codebase by eliminating unused or unnecessary functionality.
This commit removes commented-out and unused code related to RTL (right-to-left) binding handling in master pages and document saving. These changes clean up the codebase, improving maintainability and reducing potential confusion.
Removed unnecessary qFloor function call to simplify the horizontal position calculation. This change improves code readability and ensures consistent behavior without altering functionality.
Introduce support for right-to-left (RTL) binding in the Page Palette. This includes adjustments to page offsets, rendering logic, and group positioning to accurately handle RTL page layouts. A new function `set_rtl_binding` tracks the binding direction, ensuring proper visual representation.
there are some bugs but I will fix them later.
Ensure correct column index adjustment when right-to-left binding is enabled. This resolves potential issues in layout rendering for RTL documents.
This commit removes all code related to the 'binding' feature in the page layout widget, including member variables, methods, UI components, and related logic. This cleanup simplifies the codebase by eliminating unused or unnecessary functionality.
This commit removes commented-out and unused code related to RTL (right-to-left) binding handling in master pages and document saving. These changes clean up the codebase, improving maintainability and reducing potential confusion.
Removed unnecessary qFloor function call to simplify the horizontal position calculation. This change improves code readability and ensures consistent behavior without altering functionality.
@Gseeker-My

Copy link
Copy Markdown

Hi @Fahad-Alsaidi 👋

I'm an Arabic-language Scribus user on Windows. The default
left-side binding has been a real blocker for me — your RTL
binding work is exactly what I need.

Would you be willing to share a Windows build of this branch?
I tried the existing "First Page is: Right Page" setting in
Scribus 1.6.6 and it doesn't actually flip the spread order
(page 1 still sits on the left of the spread, then 2|3, 4|5
left-to-right) — your PR seems to fix exactly that.

If a Windows .exe / installer isn't easy to share, even a
Linux AppImage would help.

Thanks for working on this!

@Fahad-Alsaidi

Copy link
Copy Markdown
Contributor Author

Hi @Fahad-Alsaidi 👋

I'm an Arabic-language Scribus user on Windows. The default left-side binding has been a real blocker for me — your RTL binding work is exactly what I need.

Would you be willing to share a Windows build of this branch? I tried the existing "First Page is: Right Page" setting in Scribus 1.6.6 and it doesn't actually flip the spread order (page 1 still sits on the left of the spread, then 2|3, 4|5 left-to-right) — your PR seems to fix exactly that.

If a Windows .exe / installer isn't easy to share, even a Linux AppImage would help.

Thanks for working on this!

Salam,
I have two news for you. one good the other bad. The good news is that this branch got merged into the upstream on 2026-04-29 and will be in the next release of Scribus 1.7.4svn.
The bad news, you have to wait or you can build it by yourself.

@Fahad-Alsaidi

Fahad-Alsaidi commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

@Gseeker-My
17.4 dev relase build for window you can try it
https://sourceforge.net/projects/scribus/files/scribus-svn/1.7.4.svn/

@Gseeker-My

Copy link
Copy Markdown

@Gseeker-My 17.4 dev relase build for window you can try it https://sourceforge.net/projects/scribus/files/scribus-svn/1.7.4.svn/

salam
thank you for your come back ,i will try it right now !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants