AB#671 - Inline @hsl-fi/design-system-core styles instead of leaving them as a passthrough import - #5901
Merged
Merged
Conversation
… passthrough import.
vesameskanen
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
AI summary:
Root cause:
sass/_main.scss imported @hsl-fi/design-system-core/css/styles.css with an explicit .css extension. Dart Sass leaves .css -suffixed imports as literal passthroughs instead of inlining them, so webpack's splitChunks picked it up as its own module (resolved under node_modules/@hsl-fi/ ) and extracted it into the shared digitransit-components.css chunk — which loads after each theme's own CSS in the HTML. Since @hsl-fi/design-system-core@2.7.1 added --font-weight-medium: 500 / --font-weight-book to that stylesheet, it silently overrode every non-HSL theme's correct value sitewide (HSL coincidentally used 500 already, so it looked fine there).
Fix:
dropped the .css extension so Sass inlines the file directly into sass/_main.scss , before base/helper-mixins (which sets each theme's real value) — restoring correct cascade order within a single file.
Verified:
stylelint clean, 52/52 trafficnow tests pass, and a real production build ( CONFIG=oulu ) confirms --font-weight-medium now resolves to 600 in the theme bundle, is gone from the shared chunk, and all other design-system-core tokens (colors/shadows) remain intact.