Repository navigation
Fix math rounding by converting view rect to the bitmap rect and back in ImageView::Draw() - #707
Conversation
in ImageView::Draw(). Fixes HaikuArchives#706
|
Hey @dsizzle, nice to see you back again! Did they let you out of your cubicle for a bit to stretch your coding legs? :) FWIW, this PR does fix the jiggly checkers. But even with #702 being merged, I still see flickering of the image, i.e. I see the checkers of the background flickering through the image when resizing from another corner than the bottom right (with CTRL+ALT+right-mousebutton). |
|
hi @humdingerb! The flickering is unfortunate :( because on my end the flicker is gone completely, which is why I merged #702. Maybe I'll try playing with it some more. But I'm glad to hear this jiggling fix works! |
|
Should we merge this? It does seem to improve the situation. Although: The whole image jiggles on resize, when you use the CTRL+ALT-resizing instead of the resize corner. Weirdly. Still, an improvement… |
|
I think we should merge this, but probably have more to do for #697 |
|
Let's merge then. |
This fixes the slight "jiggling" when zoomed in, that seems to be caused by slight differences in rounding when converting between the scaled view and the actual image itself.
Fixes #706