Skip to content

Fix math rounding by converting view rect to the bitmap rect and back in ImageView::Draw() - #707

Merged
humdingerb merged 1 commit into
HaikuArchives:masterfrom
dsizzle:706-bg-jiggle
Oct 23, 2026
Merged

humdingerb merged 1 commit into
HaikuArchives:masterfrom
dsizzle:706-bg-jiggle

Conversation

@dsizzle

@dsizzle dsizzle commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

This fixes the slight "jiggling" when zoomed in, that seems to be caused by slight differences in rounding when converting between the scaled view and the actual image itself.

Fixes #706

@humdingerb

Copy link
Copy Markdown
Member

Hey @dsizzle, nice to see you back again! Did they let you out of your cubicle for a bit to stretch your coding legs? :)

FWIW, this PR does fix the jiggly checkers. But even with #702 being merged, I still see flickering of the image, i.e. I see the checkers of the background flickering through the image when resizing from another corner than the bottom right (with CTRL+ALT+right-mousebutton).

@dsizzle

dsizzle commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

hi @humdingerb! The flickering is unfortunate :( because on my end the flicker is gone completely, which is why I merged #702. Maybe I'll try playing with it some more.

But I'm glad to hear this jiggling fix works!

@humdingerb

Copy link
Copy Markdown
Member

Should we merge this? It does seem to improve the situation.

Although: The whole image jiggles on resize, when you use the CTRL+ALT-resizing instead of the resize corner. Weirdly. Still, an improvement…

@dsizzle

dsizzle commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

I think we should merge this, but probably have more to do for #697

@humdingerb

Copy link
Copy Markdown
Member

Let's merge then.

@humdingerb
humdingerb merged commit d51b15e into HaikuArchives:master Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Background jiggle in zoomed view

2 participants