Adapt RadioNetwork stationfinder to new API - #73
Open
fishpond-haiku wants to merge 4 commits into
Open
fishpond-haiku wants to merge 4 commits into
fishpond-haiku wants to merge 4 commits into
Conversation
Enhance stations finder plug interface (even though only one working service left) and adapt to new RadioNetwork API, using dropdowns for country or codec searches. Removed DNS caching and failover again, only one Radionetwork server left.
Signed-off-by: fishpond-haiku <kai.niessen@online.de>
|
New to pull requests - pls do not hesitate to update the request or advise me on best practice. |
Member
|
It's a rather large change. I'm ill equipped to review even small changes … :) |
Contributor
Author
|
Anything I can do? |
Member
|
As mentioned, I cannot be trusted to review anything but the most basic stuff… I would propose - since you've contributed valuable changes in the past - we trust these changes are OK. I did build the code and it does work (I'm not an actual user of streaming radio, though). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got back to Haiku R6 - congrats on that. Found that my old app StreamRadio had actually been updated through the years (thx HaikuArchives team!) but now was unable to do stations searches. RadioNetwork switched to a new REST API, so I updated the app accordingly. Some fixes on the way,as usually...
Best,
Kai / Fishpond