Skip to content

Added balancing groups and common group receiver #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ethouris wants to merge 54 commits into
base: dev
Choose a base branch
from

Merged with latest dev and fixed. Fixed managed flag on accepted memb…

5115561
Select commit
Loading
Failed to load commit list.
Draft

Added balancing groups and common group receiver #2885

Merged with latest dev and fixed. Fixed managed flag on accepted memb…
5115561
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Feb 13, 2026 in 5s

39 new alerts

New alerts in code changed by this pull request

  • 5 warnings
  • 34 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 130 in srtcore/queue.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
Loading
may be assigned to a non-local variable.

Check warning on line 682 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 122 lines.

Check warning on line 2230 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of integer where enum is preferred Warning

Enumeration types should be used instead of integers to select from a limited series of choices.

Check warning on line 1222 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of integer where enum is preferred Warning

Enumeration types should be used instead of integers to select from a limited series of choices.

Check warning on line 1452 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of integer where enum is preferred Warning

Enumeration types should be used instead of integers to select from a limited series of choices.

Check notice on line 24 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unused static function Note

Static function fmt_onoff is unreachable

Check notice on line 65 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 430 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Long switch case Note

Switch has at least one case that is too long:
SRTO_GROUPMINSTABLETIMEO (31 lines)
Loading
.

Check notice on line 1025 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1172 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1476 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1841 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1994 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 3076 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 3402 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 3714 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 3783 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 3829 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 4049 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 5451 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.

Check notice on line 5872 in srtcore/group.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 2230 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Long switch case Note

Switch has at least one case that is too long:
SRT_CMD_KMREQ (44 lines)
Loading
.

Check notice on line 1537 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 4215 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 4605 in srtcore/core.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.