feat(nano): execute standalone transfer headers#1654
Open
jansegre wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/nano/transfer-header #1654 +/- ##
=============================================================
- Coverage 85.01% 85.00% -0.02%
=============================================================
Files 480 480
Lines 30162 30283 +121
Branches 4526 4561 +35
=============================================================
+ Hits 25643 25741 +98
- Misses 3615 3622 +7
- Partials 904 920 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c50cae0 to
1672ba9
Compare
2 tasks
1672ba9 to
791dd28
Compare
438188c to
f12e584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is part of the implementation of RFC #108. The prior commits on this branch added the
TransferHeaderformat, validation, and the underlying global address-balance state; this step wires standalone transfer-header transactions into block execution so they actually move funds in the global balance map.Before this change, only nano-contract transactions were picked up by the block executor. Transactions that carry only a
TransferHeader(no nano-contract call) were parsed and validated but had no effect on state. This PR makes them first-class participants in block execution alongside nano-contract calls.Acceptance Criteria
NCInsufficientFundswhen an input address lacks balance.NCBlockStorageexplicitly (not only aRunner), letting the consensus layer commit state for transfer-header txs, voided nano txs (seqnum-only updates), and failed nano txs that still need their partial state persisted.(address, seqnum)from either a nano header or a transfer header, so transfer-header-only txs are ordered correctly relative to nano calls sharing an address.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged