Repository navigation
Redesign account settings and align create/edit modals - #1408
Merged
Merged
Conversation
Replace the tabbed account settings and profile pages with a single settings area at /settings, using the app's sidebar layout: - Personal: Profile, Security (password + two-factor) - Account: General, Organizers, Team, Taxes and fees - Old /account/* and /manage/profile* URLs redirect, so links in emails already sent keep working - Delete account lists the upcoming events blocking deletion, with links to their orders (new blocking_events on the deletion status endpoint) Move every create/edit modal onto the shared Modal with a sticky ModalFooter (Cancel + primary action). Modals go full-screen on phones with the footer pinned to the bottom. Redesign the tax/fee and create organizer modals. Also frame-protect /settings, refresh cached account data after saving, add translations for all locales, and update the E2E specs.
|
This PR was not deployed automatically as @max-1-max does not have access to the Railway project. In order to get automatic PR deploys, please add @max-1-max to your workspace on Railway. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Account settings and the profile page were two separate tabbed pages under a plain top bar. This replaces both with one settings area at
/settingsthat uses the app's sidebar layout, and brings every create/edit modal onto a shared design.Settings area
SettingsPage/SettingsSection/SettingsRowpieces. Forms show an "Unsaved changes" footer with Discard and Save, and stay in sync with server data after saving./account/*,/manage/accountand/manage/profile*redirect, so links in emails already sent keep working. Backend email links now point to the new paths.blocking_eventsfield.Modals
Modalwith a stickyModalFooter(Cancel plus the primary action, and an optional slot on the left for destructive actions). On phones the modal goes full-screen with the footer pinned to the bottom.EditOrganizerModal,HeadingCard,TaxAndFeeListand the old pages.Other
/settingsis frame-protected inserver.js.Test plan
blocking_eventsscramble:analyzeand pint are cleantsc: no new errors🤖 Generated with Claude Code