hurrican: full stack working on darwin#93
Open
philocalyst wants to merge 4 commits into
Open
Conversation
for a cleaner and more predictable log location
Author
|
@drfiemost @thrimbor would love feedback here |
Member
|
There is a lot of stuff going on here, can you please open a separate PR for each logical change? |
Author
|
I really dread working through the github UI, and the git rewriting interface, is there anyway we could work through it here? The diff is bloated by the plist, and each commit is a logical change. There's just not many of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
put some time into this today because I wanted to package it for nixpkgs! There were some small issues I got with filepathing, but the bigger issue with what macos expects from openGL, which took the bulk of my time, but now works excellently!
Also includes a plist and icons file for that nice packaging.