fix fingerprint use of mutable fields and detection node filtering - #270
Merged
Conversation
willr3
force-pushed
the
fix_fingerprint_mutability
branch
from
August 19, 2026 11:22
7b14f3b to
26ddc80
Compare
stalep
reviewed
Aug 21, 2026
stalep
left a comment
stalep
left a comment
Member
There was a problem hiding this comment.
I think this pr looks good. We probably need to expose a method to fetch the fingerprint names for the cli and web ui.
willr3
force-pushed
the
fix_fingerprint_mutability
branch
from
August 21, 2026 11:26
26ddc80 to
b1d5d9a
Compare
willr3
force-pushed
the
fix_fingerprint_mutability
branch
from
August 21, 2026 11:31
b1d5d9a to
f695b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation for fingerprint stores the source node names in the ValueEntity whenever it calculates a new Value. The name is a mutable field and storing it means having to potentially recalculate all fingerprints whenever a source node name changes. Instead, this PR changes fingerprints to using the source node ids as keys (an immutable field) and recreates the
{ [name] : value}object whenever it is needed for a DetectionNode's fingerprintFilter.This PR will also update DetectionNode fingerprintFilters whenever the node name changes for the associated FingerprintNode. This will keep the filter in sync with mutable node name. The update uses the same method we currently use to keep JsNode parameter names in sync with name mutations to their source nodes.