Skip to content

Standardize CLI verb consistency and restructure admin commands - #281

Open
stalep wants to merge 1 commit into
Hyperfoil:mainfrom
stalep:issue_277
Open

Standardize CLI verb consistency and restructure admin commands#281
stalep wants to merge 1 commit into
Hyperfoil:mainfrom
stalep:issue_277

Conversation

@stalep

@stalep stalep commented Aug 21, 2026

Copy link
Copy Markdown
Member

Fix #278: Standardize CRUD verbs across all entity groups. Change 'view create' to 'view add' (with 'create' as alias for backwards compatibility), matching folder/node/notification which all use 'add'.

Fix #277: Restructure admin commands from flat verb-noun naming (create-team, list-users, etc.) to nested entity groups matching the noun-verb pattern used by all other entity commands.

Before:
admin create-team|create-user|list-teams|list-users|add-member|
create-api-key|list-api-keys|revoke-api-key

After:
admin team → add, list
admin user → add, list
admin member → add
admin apikey → add, list, revoke

This makes admin consistent with the entity-first pattern:
folder → add, list, remove, upload, values, ...
node → add, list, remove, update
view → add, list, remove, show, update
admin team → add, list
admin apikey → add, list, revoke

close #277
close #278

Fix Hyperfoil#278: Standardize CRUD verbs across all entity groups. Change
'view create' to 'view add' (with 'create' as alias for backwards
compatibility), matching folder/node/notification which all use 'add'.

Fix Hyperfoil#277: Restructure admin commands from flat verb-noun naming
(create-team, list-users, etc.) to nested entity groups matching the
noun-verb pattern used by all other entity commands.

Before:
  admin create-team|create-user|list-teams|list-users|add-member|
        create-api-key|list-api-keys|revoke-api-key

After:
  admin team    → add, list
  admin user    → add, list
  admin member  → add
  admin apikey  → add, list, revoke

This makes admin consistent with the entity-first pattern:
  folder → add, list, remove, upload, values, ...
  node   → add, list, remove, update
  view   → add, list, remove, show, update
  admin team   → add, list
  admin apikey → add, list, revoke

close Hyperfoil#277
close Hyperfoil#278
@willr3

willr3 commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

I'm away from the laptop to check the code but why are we using the 'admin' prefix for the member, apikey, and team entities? Also why does apikey use revoke instead of remove for the verb? I realize revoking a key is a common verb for keys but I thought verb inconsistency was one of the justifications for changing to noun->verb syntax

@willr3

willr3 commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

with 'create' as alias for backwards compatibility

I find it questionable that we are suddenly trepidatious about backward compatibility for a verb when a single PR changed the syntax of every command and broke non-REPL command invocation. I think we do not need to retain 'create' for backwards compatibility and honestly feel retaining it would lead to confusion on why there were two similar verbs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

command verbs are not consistent across entities admin commands use verb->noun breaking cli consistency

2 participants