extend the iteration_detection filter to use dialect-based event filtering - #123
Open
lasch wants to merge 1 commit into
Open
extend the iteration_detection filter to use dialect-based event filtering#123lasch wants to merge 1 commit into
lasch wants to merge 1 commit into
Conversation
…ering Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
lasch
requested review from
Rafael-Sadykov,
WarningRan,
aishwariyachakraborty,
ppnaik1890 and
yuhaohaoyu
as code owners
August 6, 2026 16:06
ppnaik1890
reviewed
Aug 10, 2026
| assert isinstance(context, IterationDectectContext) | ||
|
|
||
| if event["ph"] in "X" and "args" in event and "TS1" in event["args"] and "Cmpt Exec" in event["name"]: | ||
| if event["ph"] == "X" and PipelineContextTool.is_acc_kernel(event): |
Collaborator
There was a problem hiding this comment.
Hi @lasch. Is this update not required for DMAI, DMAO and Cmpt Prep as well?
Member
Author
There was a problem hiding this comment.
The iteration detection (so far) was purely based on compute kernel name sequences. Therefore, memory ops don't need to be detected/handled here.
In general, there was no need for extra helper functions for memory ops yet, because the dialect feature already supports has the general fn-call is_category. For example: PipelineContextTool.is_category("acc_datatransfer_DtoH") would be the dialect-agnostic check for DmaO ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing event filtering in the iteration detection function was still using hard-coded conditions for flex traces.
This PR updates this to use dialect-based accelerator kernel detection and thus enables iteration detection for torch traces.