-
Notifications
You must be signed in to change notification settings - Fork 36
Devin Fledermaus #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Devin Fledermaus #44
Changes from 37 commits
88a0c43
69a305f
95cabc6
5f81214
75bff11
3b59290
6de1c55
7bd7bc8
7991e74
c54940f
3e5eae5
b028cc4
dfc1c75
6c53b8d
6a9233b
708034d
027f290
c4039ef
ecceaf0
5ff3563
405592d
c67502c
7cf9e78
708ef31
1256e0c
93e2511
0b1c2e6
876307b
d2cf1df
e31c2d3
f5fdd2d
951158c
46fc0eb
b581516
4d5c1a5
f2457da
ade9748
cdaf8aa
b72ecd9
7b4e7a6
62417f3
d3ad477
e82ac48
4bdde48
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,285 @@ | ||
| let fromParameter = 0; | ||
| let timer: number; | ||
| let recordCount: number; | ||
|
|
||
| //// On Window Load | ||
| window.onload = function () { | ||
| getRecordCount() | ||
| .then(() => { | ||
| return getHeadings(); | ||
| }) | ||
| .then(() => { | ||
| return getTable(); | ||
| }); | ||
| console.log("CALL HECTOR!!!"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stray console log. |
||
| }; | ||
|
|
||
| function getParameters(fromParameter: number) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a return type |
||
| let toParameter: number; | ||
| let noOfRows = getNoOfRows(); | ||
|
|
||
| toParameter = fromParameter + noOfRows; | ||
| return toParameter; | ||
| } | ||
|
|
||
| function getNoOfRows(): number { | ||
| const height = window.innerHeight; | ||
| let noOfRows = Math.floor(height / 40); | ||
| return noOfRows; | ||
| } | ||
|
|
||
| //// Functions To Create/Clear The HTML | ||
| // Heading Row | ||
| function createHeadingRow(headingData: string) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on how you are using this function in your code, you should probably rename it to |
||
| const heading: HTMLElement | null = document.getElementById("heading"); | ||
|
|
||
| let headings = `<div class="headings" id="headings">${headingData}</div>`; | ||
| if (heading !== null) { | ||
| heading.innerHTML += headings; | ||
| } | ||
| } | ||
|
|
||
| // Table Content | ||
| function createTableContent(contentData: string) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They way you are using |
||
| const content: HTMLElement | null = document.getElementById("content"); | ||
|
|
||
| let table = `<div id="row-${contentData[0]}" class="rows"></div>`; | ||
| if (content !== null) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You probably want to stop the function at this point, and tell the user something is wrong, as the rest of this function is dependent on this having a value. |
||
| content.innerHTML += table; | ||
| } | ||
|
|
||
| let rows: HTMLElement | null = document.getElementById("row-" + contentData[0]); | ||
| for (let x = 0; x < contentData.length; x++) { | ||
| let rowCols = `<div class="row_cols">${contentData[x]}</div>`; | ||
| if (rows !== null) { | ||
| rows.innerHTML += rowCols; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| //// Fetch Requests | ||
| // Response Error Handling | ||
| function handleErrors(response: Response) { | ||
| if (!response.ok) { | ||
| throw Error(response.statusText); | ||
| } | ||
| return response; | ||
| } | ||
|
|
||
| // Heading Row (Getting the columns data) | ||
| function getHeadings() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a return type. |
||
| return fetch("http://localhost:2050/columns", { | ||
| method: "GET", | ||
| headers: { "Content-Type": "application/json" }, | ||
| }) | ||
| .then(handleErrors) | ||
| .then((response) => response.text()) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather use |
||
| .then((data) => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove the |
||
| let headingData = JSON.parse(data); | ||
| for (let i = 0; i < headingData.length; i++) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change this to a |
||
| createHeadingRow(headingData[i]); | ||
| } | ||
| getParameters(0); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is the purpose of calling this function here? |
||
| }) | ||
| .catch((error: Error) => { | ||
| console.log(error); | ||
| }); | ||
| } | ||
|
|
||
| // Table Content (Getting the table's data) | ||
| function getTable() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a return type. |
||
| const content: HTMLElement | null = document.getElementById("content"); | ||
| let toParameter = getParameters(fromParameter); | ||
| const pageStats: HTMLElement | null = document.getElementById("pageStats"); | ||
|
|
||
| // Clears Table | ||
| if (content !== null) { | ||
| content.innerHTML = ""; | ||
| } | ||
|
|
||
| // Displays The Current Results Being Shown | ||
| let currentStats = `Showing results from ${fromParameter} to ${toParameter} out of ${recordCount} results.`; | ||
| if (pageStats !== null) { | ||
| pageStats.innerHTML = currentStats; | ||
| } | ||
|
|
||
| return fetch(`http://localhost:2050/records?from=${fromParameter}&to=${toParameter}`, { | ||
| method: "GET", | ||
| headers: { "Content-Type": "application/json" }, | ||
| }) | ||
| .then(handleErrors) | ||
| .then((res: Response) => res.text()) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather use |
||
| .then((data) => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove the |
||
| let contentData = JSON.parse(data); | ||
| for (let i = 0; i < contentData.length; i++) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change this to a |
||
| createTableContent(contentData[i]); | ||
| } | ||
| }) | ||
| .catch((error: Error) => { | ||
| console.log(error); | ||
| }); | ||
| } | ||
|
|
||
| // Gets Total Of All Records | ||
| function getRecordCount() { | ||
| return fetch("http://localhost:2050/recordCount", { | ||
| method: "GET", | ||
| headers: { "Content-Type": "application/json" }, | ||
| }) | ||
| .then(handleErrors) | ||
| .then((res: Response) => res.text()) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather use |
||
| .then((data) => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove the |
||
| recordCount = JSON.parse(data); | ||
| }) | ||
| .catch((error: Error) => { | ||
| console.log(error); | ||
| }); | ||
| } | ||
|
|
||
| //// Debounce | ||
| function debounce(fn: any, delay: number) { | ||
| return function () { | ||
| clearTimeout(timer); | ||
| timer = setTimeout(() => { | ||
| fn(); | ||
| }, delay); | ||
| }; | ||
| } | ||
|
|
||
| //// Sizing And Resizing | ||
| function resizing() { | ||
| let end = fromParameter + getNoOfRows(); | ||
| let toParameter: number; | ||
| let maxRecordsID = recordCount - 1; | ||
|
|
||
| if (end > maxRecordsID) { | ||
| toParameter = maxRecordsID; | ||
| fromParameter = toParameter - getNoOfRows(); | ||
| } else { | ||
| toParameter = fromParameter + getNoOfRows(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the purpose of this line? |
||
| } | ||
| getTable(); | ||
| } | ||
|
|
||
| window.addEventListener("resize", debounce(resizing, 500)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line should not be in global space. |
||
|
|
||
| //// Navigation | ||
| // Next | ||
| { | ||
| let nextCount = 0; | ||
| const nextButton: HTMLElement | null = document.getElementById("next"); | ||
|
|
||
| const nextDebounce = (fn: any, delay: number) => { | ||
| return function () { | ||
| nextCount++; | ||
| clearTimeout(timer); | ||
| timer = setTimeout(() => { | ||
| fn(); | ||
| }, delay); | ||
| }; | ||
| }; | ||
|
|
||
| let next = () => { | ||
| let toParameter = getParameters(fromParameter); | ||
| let maxRecordsID = recordCount - 1; | ||
|
|
||
| if (toParameter === maxRecordsID) { | ||
| alert("You have reached the final page"); | ||
| } | ||
|
|
||
| let nextAmount = toParameter - fromParameter + 1; | ||
| let nextCountAmount = nextAmount * nextCount; | ||
| fromParameter = fromParameter + nextCountAmount; | ||
| toParameter = fromParameter + getNoOfRows(); | ||
|
|
||
| let end = fromParameter + getNoOfRows(); | ||
|
|
||
| if (end > maxRecordsID) { | ||
| toParameter = maxRecordsID; | ||
| fromParameter = toParameter - getNoOfRows(); | ||
| } | ||
|
|
||
| nextCount = 0; | ||
|
|
||
| getTable(); | ||
| }; | ||
|
|
||
| if (nextButton !== null) { | ||
| nextButton.addEventListener("click", nextDebounce(next, 500)); | ||
| } | ||
| } | ||
|
|
||
| // Previous | ||
| { | ||
| let prevCount = 0; | ||
| const prevButton: HTMLElement | null = document.getElementById("prev"); | ||
|
|
||
| const prevDebounce = (fn: any, delay: number) => { | ||
| return function () { | ||
| prevCount++; | ||
| clearTimeout(timer); | ||
| timer = setTimeout(() => { | ||
| fn(); | ||
| }, delay); | ||
| }; | ||
| }; | ||
|
|
||
| let prev = () => { | ||
| let toParameter = getParameters(fromParameter); | ||
|
|
||
| if (fromParameter === 0) { | ||
| alert("You Are On The First Page"); | ||
| } else { | ||
| let prevAmount = toParameter - fromParameter + 1; | ||
| let prevCountAmount = prevAmount * prevCount; | ||
|
|
||
| let intOne = fromParameter - prevCountAmount; | ||
|
|
||
| if (intOne < 0) { | ||
| fromParameter = 0; | ||
| } else { | ||
| fromParameter = intOne; | ||
| } | ||
|
|
||
| prevCount = 0; | ||
|
|
||
| getTable(); | ||
| } | ||
| }; | ||
|
|
||
| if (prevButton !== null) { | ||
| prevButton.addEventListener("click", prevDebounce(prev, 500)); | ||
| } | ||
| } | ||
|
|
||
| // ID Jump | ||
| { | ||
| const input: any = document.querySelector("input"); | ||
|
|
||
| let idJump = () => { | ||
| let toParameter = getParameters(fromParameter); | ||
| let currentID = fromParameter; | ||
| let search = input.value; | ||
| let end = parseInt(search) + getNoOfRows(); | ||
| let maxRecordsID = recordCount - 1; | ||
|
|
||
| if (search !== NaN && search !== "" && search <= maxRecordsID && search >= 0) { | ||
| if (end > maxRecordsID) { | ||
| toParameter = maxRecordsID; | ||
| fromParameter = toParameter - getNoOfRows(); | ||
| } else { | ||
| fromParameter = parseInt(search); | ||
| toParameter = fromParameter + getNoOfRows(); | ||
| } | ||
| } else if (search !== "") { | ||
| alert("Make Sure Your Desired ID Is Not A Negative Number Or Doesn't Exceed 999999"); | ||
| fromParameter = currentID; | ||
| toParameter = fromParameter + getNoOfRows(); | ||
| input.value = ""; | ||
| } | ||
|
|
||
| getTable(); | ||
| }; | ||
|
|
||
| window.addEventListener("input", debounce(idJump, 500)); | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a lot of logic living in global space, either move it to a class, or execute it somewhere else. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,27 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>JS Onboard Project</title> | ||
| <script type="text/javascript" charset="utf-8" src="third_party/jquery-2.0.3.min.js"></script> | ||
| </head> | ||
|
|
||
| <body> | ||
| <p>Hello</p> | ||
| </body> | ||
|
|
||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Onboarding JavaScript Task</title> | ||
| <script type="text/javascript" charset="utf-8" src="third_party/jquery-2.0.3.min.js"></script> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <script src="app.js" defer></script> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You really should not be using |
||
| </head> | ||
| <body> | ||
| <div id="nav"> | ||
| <label id="pageStats"></label> | ||
| <div id="jumpID"> | ||
| <input type="number" id="idJump" placeholder="Input A Starting ID" /> | ||
| <!-- <button>Jump to ID</button> --> | ||
| </div> | ||
| <div id="btns"> | ||
| <button class="prev" id="prev">Prev</button> | ||
| <button class="next" id="next">Next</button> | ||
| </div> | ||
| </div> | ||
| <div id="heading"></div> | ||
| <div id="content"></div> | ||
| </body> | ||
| </html> | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "name": "onboard-javascript", | ||
| "version": "1.0.0", | ||
| "description": "This is a JavaScript project for all new developers to complete before venturing into our web frontend codebase.", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "build": "tsc --build" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/Koumori97/onboard-javascript.git" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", | ||
| "bugs": { | ||
| "url": "https://github.com/Koumori97/onboard-javascript/issues" | ||
| }, | ||
| "homepage": "https://github.com/Koumori97/onboard-javascript#readme", | ||
| "dependencies": { | ||
| "typescript": "^4.6.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jquery": "^3.5.14" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an arrow function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump