Skip to content
Open
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
88a0c43
final push
FledermausDevin Apr 12, 2022
69a305f
final push
FledermausDevin Apr 12, 2022
95cabc6
final push
FledermausDevin Apr 12, 2022
5f81214
final push
FledermausDevin Apr 12, 2022
75bff11
final push
FledermausDevin Apr 12, 2022
3b59290
final push
FledermausDevin Apr 12, 2022
6de1c55
revised code attempt 1
FledermausDevin Apr 13, 2022
7bd7bc8
revised code attempt 1
FledermausDevin Apr 13, 2022
7991e74
next and prev buttons fixed
FledermausDevin Apr 14, 2022
c54940f
next and prev buttons fixed
FledermausDevin Apr 14, 2022
3e5eae5
next and prev buttons fixed
FledermausDevin Apr 14, 2022
b028cc4
revised code
FledermausDevin Apr 20, 2022
dfc1c75
revised code
FledermausDevin Apr 20, 2022
6c53b8d
window resizing
FledermausDevin Apr 21, 2022
6a9233b
window resizing
FledermausDevin Apr 21, 2022
708034d
window resizing
FledermausDevin Apr 22, 2022
027f290
resize
FledermausDevin Apr 25, 2022
c4039ef
debounce implimented
FledermausDevin Apr 25, 2022
ecceaf0
debounce implimented
FledermausDevin Apr 25, 2022
5ff3563
debounce implimented
FledermausDevin Apr 25, 2022
405592d
column aligning
FledermausDevin Apr 26, 2022
c67502c
column aligning
FledermausDevin Apr 26, 2022
7cf9e78
final testing complete
FledermausDevin Apr 26, 2022
708ef31
final testing complete
FledermausDevin Apr 28, 2022
1256e0c
revision after code review
FledermausDevin Apr 29, 2022
93e2511
revision after code review
FledermausDevin Apr 29, 2022
0b1c2e6
03 May code review revision
FledermausDevin May 3, 2022
876307b
03 May code review revision
FledermausDevin May 3, 2022
d2cf1df
03 May code review revision
FledermausDevin May 3, 2022
e31c2d3
03 May code review revision
FledermausDevin May 3, 2022
f5fdd2d
03 May code review revision
FledermausDevin May 3, 2022
951158c
4 May Code Review Implimented
FledermausDevin May 4, 2022
46fc0eb
05 May code revisied
FledermausDevin May 5, 2022
b581516
05 May code revisied
FledermausDevin May 5, 2022
4d5c1a5
05 May code revisied
FledermausDevin May 5, 2022
f2457da
06 May code revisied
FledermausDevin May 6, 2022
ade9748
06 May code revisied
FledermausDevin May 6, 2022
cdaf8aa
09 May code review
FledermausDevin May 9, 2022
b72ecd9
09 May code review
FledermausDevin May 9, 2022
7b4e7a6
09 May code review
FledermausDevin May 9, 2022
62417f3
11 May update
FledermausDevin May 11, 2022
d3ad477
11 May update
FledermausDevin May 11, 2022
e82ac48
11 May update
FledermausDevin May 11, 2022
4bdde48
12 May - Final Changes
FledermausDevin May 12, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
276 changes: 276 additions & 0 deletions app.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,276 @@
let fromParameter = 0;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many global variables here which is generally frowned upon. There are few variables that are acceptable as global variables.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Gerald said, global variables are bad. You can move them to their own class.

const getParameters = (fromParameter: number) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return type

let toParameter: number;
const height = window.innerHeight;

let noOfRows = Math.floor(height / 40);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you rather call the method getNoOfRows which you created, instead of repeating the calculation here. This will also mean you won't need the variable height.

toParameter = fromParameter + noOfRows;

return toParameter;
};

const getNoOfRows = () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return type

const height = window.innerHeight;

let number = height / 40;
let noOfRows = Math.floor(number);
return noOfRows;
};

//// Functions To Create/Clear The HTML

// Heading Row

const createHeadingRow = (headingData: string) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather remove the empty line between the variable and the comment.

const heading: any = document.querySelector("#heading");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only place you can have an any in the project is when handling data that comes from the back-end. And even then you can actually use the real type instead of any.


let headings = `<div class="headings" id="headings">${headingData}</div>`;
heading.innerHTML += headings;
};

// Table Content

const createTableContent = (contentData: string) => {
const content: any = document.querySelector("#content");

let table = `<div id="row-${contentData[0]}" class="rows"></div>`;
content.innerHTML += table;

let rows: any = document.querySelector("#row-" + contentData[0] + ".rows");
for (let x = 0; x < contentData.length; x++) {
let rowCols = `<div class="row_cols">${contentData[x]}</div>`;
rows.innerHTML += rowCols;
}
};

// Clear Table Content

const clearTable = () => {
const content: any = document.querySelector("#content");
const clear = "";

content.innerHTML = clear;
};

//// Fetch Requests

// Heading Row (Getting the columns data)

const getHeadings = () => {
fetch("http://localhost:2050/columns", {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put a return in front of the fetch, that would allow other functions to wait on this function.

method: "GET",
headers: { "Content-Type": "application/json" },
})
.then((res) => res.text())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check for an error in res here. And you either want to remove the () around the res or specify the type, because currently the compiler thinks the type is any

.then((data) => {
let headingData = JSON.parse(data);
for (let i = 0; i < headingData.length; i++) {
createHeadingRow(headingData[i]);
}
getParameters((fromParameter = 0));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary? getParameters returns your toParameter but you do nothing with the return result since you don't need it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To many braces and I would rather have this as two lines, where you explicitly call getParamter with a hard coded 0

})
.catch((error) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to remove the () around the error or specify the type, as currently the compiler thinks the type is any

console.log("Call Hector", error);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who's Hector?

});
};

// Table Content (Getting the table's data)

const getTable = () => {
let toParameter = getParameters(fromParameter);

fetch(`http://localhost:2050/records?from=${fromParameter}&to=${toParameter}`, {
method: "GET",
headers: { "Content-Type": "application/json" },
})
.then((res) => res.text())
.then((data) => {
let contentData = JSON.parse(data);
for (let i = 0; i < contentData.length; i++) {
createTableContent(contentData[i]);
}
})
.catch((error) => {
console.log(error);
});
};

// Displays The Current Results Being Shown

const stats = () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this function should not have to do a recordCount API call. The recordCount is constant throughout in this case. You can probably just build your string in here and update it.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean by recordCount is constant is that you don't have to make an API call every time you call stats since the value is going to be the same for each call.

In this case, I recommend you create a global const variable that you assign the recordCount API response once on the initial load of your program. At the moment it is a hardcoded value. Let the backend determine it.

const pageStats: any = document.querySelector("#pageStats");
let toParameter = getParameters(fromParameter);

let currentStats = `Showing results from ${fromParameter} to ${toParameter} out of 1 000 000 results.`;
pageStats.innerHTML = currentStats;
};

//// Debounce

const debounce = (fn: any, delay: number) => {
let timer: number;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add timer as a global variable. It's something I noticed with Ashton as well and he got it to work. At this stage, timer is only in the scope of this function.

return function () {
clearTimeout(timer);
timer = setTimeout(() => {
fn();
}, delay);
};
};

//// Sizing And Resizing

let resizing = () => {
let end = fromParameter + getNoOfRows();
let toParameter: number;

if (end > 999999) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use 999999. You have recordCount for the max..

toParameter = 999999;
fromParameter = toParameter - getNoOfRows();
} else {
toParameter = fromParameter + getNoOfRows();
}
clearTable();
getTable();
stats();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can definitely see these 3 functions actually being in one as it always goes together logically. They are always repeated in that order and are not too complex to be split up. It can be all together in getTable()?

};

resizing = debounce(resizing, 500);

window.addEventListener("resize", resizing);

//// On Window Load

window.onload = function () {
getHeadings();
getTable();
stats();
};

//// Navigation

// Next
{
let nextCount = 0;
const nextButton: any = document.querySelector("#next");

const nextDebounce = (fn: any, delay: number) => {
let timer: any;
return function () {
nextCount++;
clearTimeout(timer);
timer = setTimeout(() => {
fn();
}, delay);
};
};

let next = () => {
let toParameter = getParameters(fromParameter);

if (toParameter === 999999) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same vibe for recordCount

alert("You have reached the final page");
}

let nextAmount = toParameter - fromParameter + 1;
let nextCountAmount = nextAmount * nextCount;
fromParameter = fromParameter + nextCountAmount;
toParameter = fromParameter + getNoOfRows();

let end = fromParameter + getNoOfRows();

if (end > 999999) {
toParameter = 999999;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same vibe for recordCount

fromParameter = toParameter - getNoOfRows();
}

nextCount = 0;

clearTable();
getTable();
stats();
};

nextButton.addEventListener("click", nextDebounce(next, 500));
}

// Previous
{
let prevCount = 0;
const prevButton: any = document.querySelector("#prev");

const prevDebounce = (fn: any, delay: number) => {
let timer: any;
return function () {
prevCount++;
clearTimeout(timer);
timer = setTimeout(() => {
fn();
}, delay);
};
};

let prev = () => {
let toParameter = getParameters(fromParameter);

if (fromParameter === 0) {
alert("You Are On The First Page");
} else {
let prevAmount = toParameter - fromParameter + 1;
let prevCountAmount = prevAmount * prevCount;

let intOne = fromParameter - prevCountAmount;

if (intOne < 0) {
fromParameter = 0;
} else {
fromParameter = intOne;
}

toParameter = fromParameter + getNoOfRows();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary? toParameter isn't used after this?


prevCount = 0;

clearTable();
getTable();
stats();
}
};

prevButton.addEventListener("click", prevDebounce(prev, 500));
}

// ID Jump
{
const input: any = document.querySelector("input");

let idJump = () => {
let toParameter = getParameters(fromParameter);
let currentID = fromParameter;
let search = input.value;
let end = parseInt(search) + getNoOfRows();

if (search !== NaN && search !== "" && search < 1000000 && search >= 0) {
if (end > 999999) {
toParameter = 999999;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same vibe for recordCount.

fromParameter = toParameter - getNoOfRows();
} else {
fromParameter = parseInt(search);
toParameter = fromParameter + getNoOfRows();
}
} else if (search !== "") {
alert("Make Sure Your Desired ID Is Not A Negative Number Or Doesn't Exceed 999999");
fromParameter = currentID;
toParameter = fromParameter + getNoOfRows();
input.value = "";
} else {
//pass
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean. You can completely remove this else since is does nothing.


clearTable();
stats();
getTable();
};

window.addEventListener("input", debounce(idJump, 500));
}
36 changes: 25 additions & 11 deletions index.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,27 @@
<!DOCTYPE html>
<html>
<head>
<title>JS Onboard Project</title>
<script type="text/javascript" charset="utf-8" src="third_party/jquery-2.0.3.min.js"></script>
</head>

<body>
<p>Hello</p>
</body>

<html lang="en">
<head>
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Onboarding JavaScript Task</title>
<script type="text/javascript" charset="utf-8" src="third_party/jquery-2.0.3.min.js"></script>
<link rel="stylesheet" href="style.css" />
<script src="app.js" defer></script>
</head>
<body>
<div id="nav">
<label id="pageStats"></label>
<div id="jumpID">
<input type="number" id="idJump" placeholder="Input A Starting ID" />
<!-- <button>Jump to ID</button> -->
</div>
<div id="btns">
<button class="prev" id="prev">Prev</button>
<button class="next" id="next">Next</button>
</div>
</div>
<div id="heading"></div>
<div id="content"></div>
</body>
</html>

28 changes: 28 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"name": "onboard-javascript",
"version": "1.0.0",
"description": "This is a JavaScript project for all new developers to complete before venturing into our web frontend codebase.",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"build": "tsc --build"
},
"repository": {
"type": "git",
"url": "git+https://github.com/Koumori97/onboard-javascript.git"
},
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/Koumori97/onboard-javascript/issues"
},
"homepage": "https://github.com/Koumori97/onboard-javascript#readme",
"dependencies": {
"typescript": "^4.6.3"
},
"devDependencies": {
"@types/jquery": "^3.5.14"
}
}
Loading