Skip to content

Security: patch critical vulnerabilities and remove hardcoded secrets - #2566

Open
gorevyoneticisi wants to merge 16 commits into
IceWhaleTech:mainfrom
gorevyoneticisi:security-fixes
Open

gorevyoneticisi wants to merge 16 commits into
IceWhaleTech:mainfrom
gorevyoneticisi:security-fixes

refactor: add ValidatePath/ValidatePaths helpers to reduce duplication

e4957e2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 4, 2026 in 26s

Quality Gate failed

Annotations

Check warning on line 106 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPj&open=AZ_ObZFJYxMmyirvnWPj&pullRequest=2566

Check warning on line 303 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQK&open=AZ_ObZFJYxMmyirvnWQK&pullRequest=2566

Check warning on line 355 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQg&open=AZ_ObZFJYxMmyirvnWQg&pullRequest=2566

Check warning on line 72 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function 'FormatDisk' should be named in snake case.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPL&open=AZ_ObZFJYxMmyirvnWPL&pullRequest=2566

Check failure on line 251 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWP_&open=AZ_ObZFJYxMmyirvnWP_&pullRequest=2566

Check warning on line 264 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQB&open=AZ_ObZFJYxMmyirvnWQB&pullRequest=2566

Check warning on line 355 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQh&open=AZ_ObZFJYxMmyirvnWQh&pullRequest=2566

Check warning on line 297 in pkg/utils/file/file.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Group together these consecutive parameters of the same type.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFsYxMmyirvnWQp&open=AZ_ObZFsYxMmyirvnWQp&pullRequest=2566

Check warning on line 358 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function 'UDEVILUmount' should be named in snake case.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQi&open=AZ_ObZFJYxMmyirvnWQi&pullRequest=2566

Check warning on line 131 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPs&open=AZ_ObZFJYxMmyirvnWPs&pullRequest=2566

Check warning on line 77 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPU&open=AZ_ObZFJYxMmyirvnWPU&pullRequest=2566

Check warning on line 354 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQb&open=AZ_ObZFJYxMmyirvnWQb&pullRequest=2566

Check warning on line 358 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQj&open=AZ_ObZFJYxMmyirvnWQj&pullRequest=2566

Check warning on line 291 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function 'GetDockerDataRoot' should be named in snake case.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQF&open=AZ_ObZFJYxMmyirvnWQF&pullRequest=2566

Check warning on line 65 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPK&open=AZ_ObZFJYxMmyirvnWPK&pullRequest=2566

Check warning on line 73 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPO&open=AZ_ObZFJYxMmyirvnWPO&pullRequest=2566

Check warning on line 32 in internal/sign/sign.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Group together these consecutive parameters of the same type.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZH6YxMmyirvnWQx&open=AZ_ObZH6YxMmyirvnWQx&pullRequest=2566

Check warning on line 161 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function 'ReloadSamba' should be named in snake case.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWP1&open=AZ_ObZFJYxMmyirvnWP1&pullRequest=2566

Check warning on line 4 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWOx&open=AZ_ObZFJYxMmyirvnWOx&pullRequest=2566

Check failure on line 41 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWO_&open=AZ_ObZFJYxMmyirvnWO_&pullRequest=2566

Check warning on line 142 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPz&open=AZ_ObZFJYxMmyirvnWPz&pullRequest=2566

Check warning on line 105 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPh&open=AZ_ObZFJYxMmyirvnWPh&pullRequest=2566

Check warning on line 167 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWP3&open=AZ_ObZFJYxMmyirvnWP3&pullRequest=2566

Check warning on line 295 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function 'SetLink' should be named in snake case.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWQH&open=AZ_ObZFJYxMmyirvnWQH&pullRequest=2566

Check failure on line 77 in build/sysroot/usr/share/casaos/shell/helper.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.

See more on https://sonarcloud.io/project/issues?id=IceWhaleTech_CasaOS&issues=AZ_ObZFJYxMmyirvnWPT&open=AZ_ObZFJYxMmyirvnWPT&pullRequest=2566