Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security: patch critical vulnerabilities and remove hardcoded secrets #2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Security: patch critical vulnerabilities and remove hardcoded secrets #2566
Changes from 4 commits
1505e16d12195d84c6cb00b24b774b7312395243efeedf5474b46a1f0ad8d1975f1dd47bf0e22c45b1326e7b01cdaf4ddec59eff8e4957e2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 4 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check failure on line 5 in build/sysroot/usr/share/casaos/shell/helper.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 7 in build/sysroot/usr/share/casaos/shell/helper.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 23 in build/sysroot/usr/share/casaos/shell/helper.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check warning on line 47 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check failure on line 58 in build/sysroot/usr/share/casaos/shell/helper.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check warning on line 65 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'GetLocalJoinNetworks' should be named in snake case.
Check warning on line 65 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 72 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'FormatDisk' should be named in snake case.
Check warning on line 73 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 79 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 82 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 90 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 100 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'AddPartition' should be named in snake case.
Check warning on line 100 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 103 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 105 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 106 in build/sysroot/usr/share/casaos/shell/helper.sh
Replace backticks with '$()' syntax for command substitution.
Check warning on line 109 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 114 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'GetDiskType' should be named in snake case.
Check warning on line 120 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'GetPlugInDisk' should be named in snake case.
Check warning on line 130 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 131 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 137 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 138 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 138 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 142 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'AutoRemoveUnuseDir' should be named in snake case.
Check failure on line 173 in build/sysroot/usr/share/casaos/shell/helper.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check warning on line 223 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 245 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check failure on line 250 in build/sysroot/usr/share/casaos/shell/helper.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check warning on line 263 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 294 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'SetLink' should be named in snake case.
Check warning on line 317 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 330 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 335 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 335 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'RestartSMBD' should be named in snake case.
Check warning on line 340 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'EditSmabaUserPassword' should be named in snake case.
Check warning on line 340 in build/sysroot/usr/share/casaos/shell/helper.sh
Add an explicit return statement at the end of the function.
Check warning on line 346 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 353 in build/sysroot/usr/share/casaos/shell/helper.sh
Function 'MountCIFS' should be named in snake case.
Check warning on line 354 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 354 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Check warning on line 354 in build/sysroot/usr/share/casaos/shell/helper.sh
Assign this positional parameter to a local variable.
Uh oh!
There was an error while loading. Please reload this page.