Convert .thens to async/awaits#1527
Merged
Merged
Conversation
Member
|
This LGTM, can you base it on master and then later rebase #1519 on top? |
annehaley
force-pushed
the
async-and-errs
branch
from
3cafdcf to
7568855
Compare
Open
danlamanna
force-pushed
the
async-and-errs
branch
from
7568855 to
5194c33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to these comments on #1519: x, x, x.
This PR refactors all instances of
.thenasasync/awaitfunctions withtry/catchblocks for more consistent error handling. If an error is encountered, we send a generic alert to the user and rethrow the error so it can be captured by Sentry.