feat: added rawvideo rgba support - #383
Open
JaimeShirazi wants to merge 1 commit into
Open
Conversation
Having to create temporary png files when piping isn't ideal, so with this you should be able to pipe raw RGBA directly into gifski
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been needing this for my animated image converter GUI, it uses YUV4MPEG for opaque stuff but having to create temporary png files on the user's drive when piping a transparent source isn't ideal, so with this you should be able to pipe raw RGBA directly into gifski (YUV4MPEG is still the better choice when fully opaque due to lower memory usage though).
I tried to follow the existing structure by allowing raw to coexist with the way YUV has been implemented, but since raw has no metadata, I did have to add a couple things (like explicit --raw-rgba/--raw-size arguments which take priority over automatic format detection)
I've been using AI to help me with rust and to help account for stuff I didn't know, I didn't see any contributing notes on AI so if it shouldn't be merged because AI is a problem whatsoever, all good, it would be great if my program could use the actual gifski repo rather than my goofy fork though, giving users the option to compile from the source.