Skip to content

POC: bring viv-dicomweb-test work into SLIM and add basic bulk annotations support #381

Open
igoroctaviano wants to merge 35 commits into
masterfrom
feat/viv-loader
Open

POC: bring viv-dicomweb-test work into SLIM and add basic bulk annotations support #381
igoroctaviano wants to merge 35 commits into
masterfrom
feat/viv-loader

Merge branch 'master' of github.com:ImagingDataCommons/slim into feat…

61f353c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 2, 2026 in 29s

Quality Gate passed

Issues
80 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 669 in src/viv/dicomLoader.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CMQNFxXeYuiD2A&open=AZ8j04CMQNFxXeYuiD2A&pullRequest=381

Check failure on line 943 in src/viv/VivSlideViewport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CkQNFxXeYuiD2X&open=AZ8j04CkQNFxXeYuiD2X&pullRequest=381

Check failure on line 131 in src/components/CaseViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 39 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04BmQNFxXeYuiD1o&open=AZ8j04BmQNFxXeYuiD1o&pullRequest=381

Check failure on line 1628 in src/viv/dicomLoader.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CMQNFxXeYuiD2I&open=AZ8j04CMQNFxXeYuiD2I&pullRequest=381

Check warning on line 12 in src/viv/vivAbortBridge.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.at(…)` over `[….length - index]`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CuQNFxXeYuiD2j&open=AZ8j04CuQNFxXeYuiD2j&pullRequest=381

Check warning on line 22 in src/preferences/iccProfilesPreference.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04DyQNFxXeYuiD2t&open=AZ8j04DyQNFxXeYuiD2t&pullRequest=381

Check warning on line 1159 in src/viv/VivSlideViewport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CkQNFxXeYuiD2a&open=AZ8j04CkQNFxXeYuiD2a&pullRequest=381

Check failure on line 1569 in src/viv/loadBulkAnnotationLayers.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04B8QNFxXeYuiD1y&open=AZ8j04B8QNFxXeYuiD1y&pullRequest=381

Check warning on line 66 in src/preferences/iccProfilesPreference.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04DyQNFxXeYuiD2w&open=AZ8j04DyQNFxXeYuiD2w&pullRequest=381

Check warning on line 28 in src/viv/vivBulkAnnDebug.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis.window` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CVQNFxXeYuiD2J&open=AZ8j04CVQNFxXeYuiD2J&pullRequest=381

Check warning on line 227 in src/viv/VivSlideViewport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CkQNFxXeYuiD2Q&open=AZ8j04CkQNFxXeYuiD2Q&pullRequest=381

Check warning on line 471 in src/App.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method 'renderCaseViewerShell' has too many parameters (8). Maximum allowed is 7. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04DXQNFxXeYuiD2q&open=AZ8j04DXQNFxXeYuiD2q&pullRequest=381

Check warning on line 84 in src/components/VivBulkAnnotationLoadIndicator.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04BFQNFxXeYuiD1k&open=AZ8j04BFQNFxXeYuiD1k&pullRequest=381

Check failure on line 1092 in src/viv/VivSlideViewport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CkQNFxXeYuiD2Y&open=AZ8j04CkQNFxXeYuiD2Y&pullRequest=381

Check failure on line 2351 in src/viv/loadBulkAnnotationLayers.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04B8QNFxXeYuiD16&open=AZ8j04B8QNFxXeYuiD16&pullRequest=381

Check warning on line 69 in src/preferences/iccProfilesPreference.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04DyQNFxXeYuiD2x&open=AZ8j04DyQNFxXeYuiD2x&pullRequest=381

Check warning on line 337 in src/viv/dicomLoader.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`new Error()` is too unspecific for a type check. Use `new TypeError()` instead. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CMQNFxXeYuiD1-&open=AZ8j04CMQNFxXeYuiD1-&pullRequest=381

Check warning on line 1707 in src/viv/loadBulkAnnotationLayers.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04B8QNFxXeYuiD11&open=AZ8j04B8QNFxXeYuiD11&pullRequest=381

Check warning on line 1557 in src/viv/VivSlideViewport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CkQNFxXeYuiD2g&open=AZ8j04CkQNFxXeYuiD2g&pullRequest=381

Check warning on line 1693 in src/viv/loadBulkAnnotationLayers.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04B8QNFxXeYuiD10&open=AZ8j04B8QNFxXeYuiD10&pullRequest=381

Check failure on line 755 in src/viv/dicomLoader.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CMQNFxXeYuiD2B&open=AZ8j04CMQNFxXeYuiD2B&pullRequest=381

Check warning on line 61 in src/viv/vivBulkAnnDebug.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The empty object is useless. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CVQNFxXeYuiD2L&open=AZ8j04CVQNFxXeYuiD2L&pullRequest=381

Check warning on line 1491 in src/viv/VivSlideViewport.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04CkQNFxXeYuiD2f&open=AZ8j04CkQNFxXeYuiD2f&pullRequest=381

Check warning on line 212 in src/components/CaseViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04BmQNFxXeYuiD1p&open=AZ8j04BmQNFxXeYuiD1p&pullRequest=381

Check warning on line 492 in src/components/CaseViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ8j04BmQNFxXeYuiD1q&open=AZ8j04BmQNFxXeYuiD1q&pullRequest=381
View more details on SonarQubeCloud