Two files under VAST 1-2.0 Samples/Tremor-Video-Samples/ do not validate against vast_2.0.1.xsd.
vast2Nonlinear.xml
Contains 10 <Ad> elements. None of the 10 <InLine> blocks contains an <Impression>. The string Impression does not appear in the file at all.
vast_2.0.1.xsd:
<xs:element name="Impression" minOccurs="1" maxOccurs="unbounded" type="Impression_type">
vast2VPAIDLinear.xml
Same missing <Impression>, plus the single <MediaFile> on line 11 declares height, width and type but not delivery:
<MediaFile height="270" width="370" type="application/x-shockwave-flash">
vast_2.0.1.xsd marks delivery as use="required" on MediaFile:
<xs:attribute name="delivery" use="required">
Why it is worth fixing
This repo gets used as a reference corpus for conformance tooling. Files that are invalid against their own declared version end up baked into test suites as expected-pass fixtures, which quietly weakens whatever is being tested.
For what it is worth, the rest of the corpus is in good shape. Validating all 75 XML files here, these two are the only ones with genuine schema violations against their declared version.
I'm happy to open a PR adding <Impression> elements and the delivery attribute. If the intent is for the Tremor samples to stay untouched as historical artifacts, a note in the folder README saying so would work just as well and would stop people treating them as conformant examples.
Two files under
VAST 1-2.0 Samples/Tremor-Video-Samples/do not validate againstvast_2.0.1.xsd.vast2Nonlinear.xmlContains 10
<Ad>elements. None of the 10<InLine>blocks contains an<Impression>. The stringImpressiondoes not appear in the file at all.vast_2.0.1.xsd:vast2VPAIDLinear.xmlSame missing
<Impression>, plus the single<MediaFile>on line 11 declaresheight,widthandtypebut notdelivery:vast_2.0.1.xsdmarksdeliveryasuse="required"onMediaFile:Why it is worth fixing
This repo gets used as a reference corpus for conformance tooling. Files that are invalid against their own declared version end up baked into test suites as expected-pass fixtures, which quietly weakens whatever is being tested.
For what it is worth, the rest of the corpus is in good shape. Validating all 75 XML files here, these two are the only ones with genuine schema violations against their declared version.
I'm happy to open a PR adding
<Impression>elements and thedeliveryattribute. If the intent is for the Tremor samples to stay untouched as historical artifacts, a note in the folder README saying so would work just as well and would stop people treating them as conformant examples.