Skip to content

CI: align named-overprint intent coverage across QA surfaces - #2343

Merged
xsscx merged 1 commit into
masterfrom
ci-qa-pr-docker-testing
Aug 30, 2026
Merged

CI: align named-overprint intent coverage across QA surfaces#2343
xsscx merged 1 commit into
masterfrom
ci-qa-pr-docker-testing

Conversation

@xsscx

@xsscx xsscx commented Aug 30, 2026

Copy link
Copy Markdown
Member

PR Summary

#2342

Checklist

  • Signed all Commits in PR
  • Built locally according to docs/build.md
  • Followed the guidelines in Contributing document
  • Ran relevant CTest/profile tests from docs/ctest.md
  • Updated documentation for user-visible behavior changes
  • Ran sanitizer coverage for memory-safety or parser changes
  • Added or updated regression coverage for behavior changes
  • Attached a base...HEAD contract matrix for cross-cutting changes:
    producer, consumer, build/runtime behavior, platform/toolchain boundary,
    CI trigger, dependency owner, and local evidence
  • Reviewed active and suppressed automated findings from review threads and summaries
  • For Python package changes, followed docs/python-packaging-release.md for PR and merge requirements
  • Did not change maintainer-owned workflow, CTest, CPack, sanitizer, release, or security infrastructure unless requested by an iccDEV maintainer
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

Legal Requirements

All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).

Contributor License Agreements

Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA)
.

There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.

  • If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.

  • If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement

License

ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.

Copyright Notices

All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.

INTELLECTUAL PROPERTY & PATENTS

Participation in ICC's development activities is subject to ICC's Patent Policy.

Maintainer Review Required

If you have questions, contact a listed Maintainer.

@xsscx xsscx added this to the v2.3.2.4 milestone Aug 30, 2026
@xsscx
xsscx requested a lite review from Copilot August 30, 2026 16:31
@xsscx xsscx self-assigned this Aug 30, 2026
@xsscx xsscx linked an issue Aug 30, 2026 that may be closed by this pull request
@github-actions github-actions Bot added pending CI checks still running Documentation Documentation-only or documentation-related change Scripts Shell, PowerShell, or repository automation scripts JSON ICC JSON parser, config, or round-trip behavior Governance Maintainer-owned policy, CODEOWNERS, prompts, or skills Unix Linux, macOS, Bash, or POSIX shell scope labels Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns CI/CTest and maintainer guidance so legacy packed intent decoding + named-color overprint coverage is consistently called out across docs, prompts, skills, and the JSON CLI exercise harness.

Changes:

  • Document the iccdev.applynamedcmm-cli-args and iccdev.applysearch-cli-args CTest suites in docs/ctest.md.
  • Add/propagate maintainer guidance to include the ApplyNamedCmm/ApplySearch CLI-args regressions alongside the named-color overprint regression.
  • Extend .github/scripts/json-cli-exercise.sh with a new group exercising named overprint intents and transform enums.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
docs/ctest.md Adds the missing CTest suite entries for the CLI-args regression scripts.
AGENTS.md Adds a ground-rule reminder to keep overprint/packed-intent coverage aligned across the named regressions.
.github/skills/maintainer-ci-ctest/SKILL.md Updates maintainer CTest selection guidance to include the relevant regressions for this behavior area.
.github/scripts/json-cli-exercise.sh Adds a new JSON CLI exercise group for named overprint intent + transform enum coverage.
.github/prompts/maintainer-ci-ctest.prompt.md Updates the maintainer prompt to explicitly include the overprint/packed-intent focused validations.
.github/copilot-instructions.md Adds the overprint + CLI-args regression scripts to the canonical list.

Comment thread .github/scripts/json-cli-exercise.sh Outdated
Comment thread .github/scripts/json-cli-exercise.sh Outdated
Comment thread .github/skills/maintainer-ci-ctest/SKILL.md Outdated
Comment thread .github/prompts/maintainer-ci-ctest.prompt.md Outdated
@xsscx
xsscx force-pushed the ci-qa-pr-docker-testing branch from 942012a to 3cec4cc Compare August 30, 2026 16:45
@xsscx
xsscx requested a lite review from Copilot August 30, 2026 16:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread .github/scripts/json-cli-exercise.sh
Comment thread .github/scripts/json-cli-exercise.sh Outdated
Signed-off-by: David Hoyt <dhoyt@hoyt.net>
@xsscx
xsscx force-pushed the ci-qa-pr-docker-testing branch from 3cec4cc to 54c9d25 Compare August 30, 2026 17:06
@xsscx
xsscx requested a lite review from Copilot August 30, 2026 17:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@xsscx
xsscx merged commit faa6b31 into master Aug 30, 2026
31 checks passed
@xsscx
xsscx deleted the ci-qa-pr-docker-testing branch August 30, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation-only or documentation-related change Governance Maintainer-owned policy, CODEOWNERS, prompts, or skills JSON ICC JSON parser, config, or round-trip behavior pending CI checks still running Scripts Shell, PowerShell, or repository automation scripts Unix Linux, macOS, Bash, or POSIX shell scope

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Add CTest for legacy packed intent decoding & named-color overprint

2 participants