Add cardonnay-sync skill - #3556
Open
OlufemiAdeOlusile wants to merge 2 commits into
Open
Conversation
OlufemiAdeOlusile
force-pushed
the
add-cardonnay-sync-skill
branch
3 times, most recently
from
July 28, 2026 10:33
868a959 to
bbd9b6a
Compare
Add a skill documenting how to point this repo's cardonnay dependency at an unreleased branch or commit so a test run actually exercises that change instead of a stale PyPI release.
OlufemiAdeOlusile
force-pushed
the
add-cardonnay-sync-skill
branch
from
July 28, 2026 10:37
bbd9b6a to
0754533
Compare
mkoura
requested changes
Jul 31, 2026
|
|
||
| ```sh | ||
| nix develop --accept-flake-config . -c bash -c "make update-uv-lock" | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Running uv lock is enough.
|
|
||
| ```sh | ||
| rm -rf run_workdir/.venv | ||
| ``` |
Collaborator
There was a problem hiding this comment.
The step 5. is not needed. The whole content of run_workdir is wiped during testrun setup anyway.
|
|
||
| 6. Now run the actual test (`runner/node_upgrade.sh`, or a plain | ||
| `make cluster-scripts && make start-cluster` for a quicker smoke check). | ||
| This is the first point where it's actually exercising the real change. |
Collaborator
There was a problem hiding this comment.
make cluster-scripts && make start-cluster is only relevant for local development and will use the existing ./.venv, so this is incorrect. The change applies only to situations when the whole env is recreated, i.e. when using runner/regression.sh, runner/node_upgrade.sh, make test-env or make install.
Simplify lock regeneration to plain `uv lock`, drop the unnecessary run_workdir/.venv cleanup step, and correct which commands actually rebuild the environment (make cluster-scripts/start-cluster reuse the existing .venv and don't exercise a synced ref).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan