properly register SV type in ChartingPointsList - #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vro what have you done to sv
also, LaneSwitchEvents and NoteEvents are already returned by Map.MapEvents.GetListsForTypes(), which mean they are registered two times, that leads to 2 entries being added to the list when adding a lane switch or a note event
this pr just does the bare minimum to make sv somewhat editable again, a lot of other things related to scroll velocities are broken by the new editor changes (SVs are displayed in the editor playfield despite being annotated with [DoNotShowInEditorPlayfield], so like im not really sure what that annotation is even supposed to do, SVs that were present when loading the maps are selectable and draggable in the editor playfield, while newly added ones are not, they still visually appear though)