Skip to content

Fix Beat Pulse Preview #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flustix merged 1 commit into from
Aug 25, 2026
Merged

Fix Beat Pulse Preview #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 50 additions & 33 deletions fluXis/Screens/Edit/Tabs/Charting/Preview/ChartingPreview.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public partial class ChartingPreview : DrawSizePreservingFillContainer
private PreviewFlashLayer backFlash = null!;
private PreviewFlashLayer frontFlash = null!;
private PulseEffect pulseEffect = null!;
private BeatPulseManager beatPulseManager = null!;

private LoadingIcon loading = null!;

Expand Down Expand Up @@ -94,8 +95,10 @@ private void load(FluXisConfig config)

camera = new CameraContainer([.. Map.MapEvents.Where(x => x is ICameraEvent).Cast<ICameraEvent>()]) { Clock = EditorClock };

Children =
[
Container pulseContainer;

Children = new Drawable[]
{
new Box { RelativeSizeAxes = Axes.Both, Colour = Theme.Background2 },
idleTracker = new IdleTracker(400, rebuildRuleset, () =>
{
Expand All @@ -106,37 +109,49 @@ private void load(FluXisConfig config)
{
ShaderEvents = compiled.ShaderEvents
},
createShaderStack().WithChildren([
camera.CreateProxyDrawable().With(x => x.Clock = EditorClock),
camera.WithChildren(new Drawable[]
{
background = new SpriteStack<BlurableBackground> { AutoFill = false },
backgroundVideo = new BackgroundVideo
{
RelativeSizeAxes = Axes.Both,
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
VideoClock = EditorClock
},
backgroundDim = new Box

camera.CreateProxyDrawable().With(x => x.Clock = EditorClock),

pulseContainer = new Container
{
RelativeSizeAxes = Axes.Both,
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
Child = createShaderStack().WithChildren<ShaderStackContainer, Drawable>([
camera.WithChildren(new Drawable[]
{
Colour = Color4.Black,
RelativeSizeAxes = Axes.Both,
Alpha = Editor.BackgroundDim,
},
backFlash = new PreviewFlashLayer { Clock = EditorClock },
rulesetWrapper = new Container { RelativeSizeAxes = Axes.Both }
}),
frontFlash = new PreviewFlashLayer { Clock = EditorClock },
pulseEffect = new PulseEffect(compiled.PulseEvents) { Clock = EditorClock }
]),
background = new SpriteStack<BlurableBackground> { AutoFill = false },
backgroundVideo = new BackgroundVideo
{
RelativeSizeAxes = Axes.Both,
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
VideoClock = EditorClock
},
backgroundDim = new Box
{
Colour = Color4.Black,
RelativeSizeAxes = Axes.Both,
Alpha = Editor.BackgroundDim,
},
backFlash = new PreviewFlashLayer { Clock = EditorClock },
rulesetWrapper = new Container { RelativeSizeAxes = Axes.Both }
}),
pulseEffect = new PulseEffect(compiled.PulseEvents) { Clock = EditorClock },
frontFlash = new PreviewFlashLayer { Clock = EditorClock }
])
},

loading = new LoadingIcon
{
Size = new Vector2(32),
Anchor = Anchor.Centre,
Origin = Anchor.Centre
}
];
};

beatPulseManager = new BeatPulseManager(Map.MapInfo, compiled.BeatPulseEvents, pulseContainer) { Clock = EditorClock };
AddInternal(beatPulseManager);
}

protected override void LoadComplete()
Expand Down Expand Up @@ -173,9 +188,10 @@ protected override void LoadComplete()
Scheduler.AddOnce(idleTracker.Reset);
};

registerListeners<LoopEvent>(rebuildAllCompiled);
registerListeners<LoopEvent>(() => rebuildAllCompiled());
registerListeners<ShaderEvent>(() => checkShaderRebuild());
registerListeners<PulseEvent>(rebuildPulseEffect);
registerListeners<BeatPulseEvent>(rebuildBeatPulse);

registerListeners<CameraMoveEvent>(rebuildCamera);
registerListeners<CameraScaleEvent>(rebuildCamera);
Expand All @@ -200,10 +216,7 @@ protected override bool OnKeyDown(KeyDownEvent e)
switch (e.Key)
{
case Key.R when e.ShiftPressed:
rebuildRuleset();
rebuildCamera();
checkShaderRebuild(true);
pulseEffect.Rebuild();
rebuildAllCompiled(true);
return true;

default:
Expand Down Expand Up @@ -329,11 +342,15 @@ private void rebuildPulseEffect()
pulseEffect.Rebuild();
}

private void rebuildAllCompiled()
private void rebuildBeatPulse() =>
beatPulseManager.Rebuild(getCompiledEvents().BeatPulseEvents);

private void rebuildAllCompiled(bool force = false)
{
checkShaderRebuild();
checkShaderRebuild(force);
rebuildCamera();
rebuildPulseEffect();
rebuildBeatPulse();
idleTracker.Reset();
}

Expand Down
Loading