fix(deps): remediate critical/high dependency vulnerabilities#10
Conversation
Bump vulnerable Go modules to patched versions: - google.golang.org/grpc 1.73.0 -> 1.81.1 (CRITICAL GHSA-p77j-4mvh-x3m3) - github.com/docker/cli 28.3.3 -> 29.2.0 (HIGH GHSA-p436-gjf2-799p) - github.com/quic-go/quic-go 0.54.0 -> 0.59.1 (HIGH GHSA-47m2-4cr7-mhcw + moderates) - go.opentelemetry.io/otel 1.37.0 -> 1.43.0 (HIGH GHSA-mh2q-q3fh-2475) - golang.org/x/crypto 0.40.0 -> 0.48.0 (moderate GHSA-f6x5/GHSA-j5w8) - filippo.io/edwards25519 1.1.0 -> 1.1.1 (low GHSA-fw7p-63qq-7hpr) - github.com/docker/docker 28.3.3 -> 28.5.2 (max on legacy module path) Pin toolchain go1.25.11 to clear two reachable stdlib advisories (GO-2026-5037 crypto/x509, GO-2026-4601 net/url) flagged by govulncheck. All vulnerable modules except docker/docker are reachable only through the bufbuild/buf codegen tool (tool directive), not the signing library. govulncheck reports zero reachable vulnerabilities after this change. Crypto and common test suites (incl. all ZKP proofs) pass unchanged. Generated by Claude Code Agent
|
Warning Review limit reached
More reviews will be available in 1 hour, 4 minutes, and 4 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
JacobPlaster
left a comment
There was a problem hiding this comment.
LGTM — no P0/P1 findings.
- Claude
Summary
Remediates the open critical + high Dependabot alerts in
go.modby bumping the affected modules to patched versions, plus most in-range moderates. All vulnerable modules other thandocker/dockerare reachable only through thebufbuild/bufcodegen tool (thetooldirective) — they are never linked into the threshold-signing library or its consumers.govulncheck(the CI security gate, which does reachability analysis) reports zero reachable vulnerabilities after this change.Remediated
Also pinned
toolchain go1.25.11to clear two reachable Go standard-library advisories that govulncheck flagged (GO-2026-5037crypto/x509, GO-2026-4601net/url).Not fixed —
github.com/docker/dockerhighs (3)GHSA-x744-4wpc-v9h2, GHSA-rg2x-37c3-w2rh, GHSA-x86f-5xw2-fm2r cannot be cleared by a version bump:
github.com/docker/docker/v29/github.com/moby/moby/v2module paths at v29. The legacygithub.com/docker/dockerpath thatbufbuild/bufimports tops out atv28.5.2(bumped to that max here) and has no patched release for these advisories.bufupstream to migrate its import tomoby/moby/v2; no releasedbufversion (latest 1.70.0) has done so.docker/dockeris pulled in solely via thebufcodegen tool, is not imported by the TSS library, andgovulncheckconfirms it is not reachable from any shipped code path.Tracked as a follow-up to bump once
bufadopts the v29/moby-v2 module path.Breaking changes
godirective bumped1.24→1.25.0. This is forced by the patched dependencies (grpc 1.81, otel 1.43, quic-go 0.59, x/crypto 0.48 all require Go 1.25). Consumers must build with Go 1.25+.Verification
go build ./...— cleango vet ./...— no new findings (pre-existing safe_prime / resharing lock-copy warnings unchanged)go mod verify— all modules verifiedgovulncheck ./...— No vulnerabilities found (0 reachable)go test ./common/... ./crypto/...— all pass, including every ZKP proof suite (affg, dec, enc, fac, logstar, mod, mul, prm, sch), Paillier, VSS, commitments. The fulltss/...keygen/signing suites were not run end-to-end (each takes many minutes); the crypto-primitive suites passing is the representative signal that signing math is unchanged.Generated by Claude Code Agent