Skip to content

fix(deps): drop vulnerable docker/docker via bufbuild/buf v1.70.0#11

Merged
PatrykMilewski merged 1 commit into
masterfrom
fix/dependabot-docker-highs
Jun 17, 2026
Merged

fix(deps): drop vulnerable docker/docker via bufbuild/buf v1.70.0#11
PatrykMilewski merged 1 commit into
masterfrom
fix/dependabot-docker-highs

Conversation

@PatrykMilewski

Copy link
Copy Markdown
Contributor

Summary

Resolves all 3 open HIGH Dependabot alerts. Before -> after: 3 high -> 0 high, 0 critical (unchanged), 0 moderate/low (none open).

All three alerts are rooted in the transitive github.com/docker/docker dependency, which is pulled in only through the tool directive github.com/bufbuild/buf/cmd/buf (protobuf codegen) — it is never linked into the threshold-signature library. govulncheck confirms zero reachable vulnerabilities both before and after.

GHSA Severity Summary Vulnerable range / patch
GHSA-rg2x-37c3-w2rh HIGH docker cp race → bind-mount redirection to host path <= 28.5.2, no patch on legacy path
GHSA-x86f-5xw2-fm2r HIGH PUT /containers/{id}/archive executes container binary on host <= 28.5.2, no patch on legacy path
GHSA-x744-4wpc-v9h2 HIGH Moby AuthZ plugin bypass on oversized request bodies patched 29.3.1

Why a buf bump (not a docker/docker bump)

The legacy github.com/docker/docker +incompatible module path tops out at v28.5.2 — the fixed 29.x line was published only on the new github.com/moby/moby module path, so the vulnerable module cannot be patched in place. buf v1.56.0 still depended on docker/docker; buf v1.70.0 migrated to github.com/moby/moby/api + .../client, removing github.com/docker/docker (and docker/cli, docker/distribution) from the module graph entirely.

Changes

  • github.com/bufbuild/buf v1.56.0v1.70.0 (indirect, tool directive) and its transitive deps.
  • github.com/docker/docker removed from go.mod/go.sum (0 references remaining).
  • go directive 1.25.01.25.10 (buf v1.70.0 minimum), under the existing toolchain go1.25.11.
  • No source changesgo.mod/go.sum only. No cryptographic behavior is touched.

Breaking changes

None for consumers of this library. The only direct-dependency surface change is the go directive minimum (1.25.01.25.10); all changes are build-time/tooling-only (buf codegen path) and docker/docker was never in the import graph of the signing code.

Verification

  • go build ./... — passes
  • make test_ci (go test -failfast -race -timeout 60m, fresh keygen/resharing fixtures regenerated) — all packages pass, no data races
  • govulncheck ./... — "No vulnerabilities found"

Generated by Claude Code Agent

Resolves all 3 open HIGH Dependabot alerts, all rooted in the transitive
github.com/docker/docker dependency (legacy +incompatible module path):

- GHSA-rg2x-37c3-w2rh  docker cp race -> bind-mount redirection to host (<= 28.5.2, no legacy patch)
- GHSA-x86f-5xw2-fm2r  PUT /containers/{id}/archive executes binary on host (<= 28.5.2, no legacy patch)
- GHSA-x744-4wpc-v9h2  Moby AuthZ plugin bypass on oversized request bodies (patched 29.3.1)

docker/docker was pulled in only through the `tool` directive
github.com/bufbuild/buf/cmd/buf (protobuf codegen) and is never linked into
the signing library (govulncheck: no reachable vulnerabilities). The legacy
github.com/docker/docker module path tops out at v28.5.2 and cannot reach the
patched 29.x line, because Docker moved 29.x to the github.com/moby/moby path.
buf v1.70.0 migrated off docker/docker to github.com/moby/moby/api and
.../client, removing the vulnerable module from the graph entirely.

No source changes; only go.mod/go.sum. The `go` directive moves 1.25.0 ->
1.25.10 (buf v1.70.0 minimum), still under the existing toolchain go1.25.11.

Verified: go build ./... and `make test_ci` (go test -race, 60m timeout, fresh
keygen/resharing fixtures) both pass; govulncheck reports no vulnerabilities.

Generated by Claude Code Agent
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PatrykMilewski, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 38 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 26573372-a4f1-4af2-935e-72ccd28539ca

📥 Commits

Reviewing files that changed from the base of the PR and between 576cc80 and bc1716d.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dependabot-docker-highs

Comment @coderabbitai help to get the list of available commands and usage tips.

@PatrykMilewski
PatrykMilewski enabled auto-merge (squash) June 16, 2026 14:02

@fabian-dios fabian-dios left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — verified this PR contains only dependency changes (go.mod/go.sum) remediating the cited Dependabot advisories, with no source-code modifications.

@PatrykMilewski
PatrykMilewski merged commit 1f549c5 into master Jun 17, 2026
6 of 7 checks passed
@PatrykMilewski
PatrykMilewski deleted the fix/dependabot-docker-highs branch June 17, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants