fix(deps): drop vulnerable docker/docker via bufbuild/buf v1.70.0#11
Conversation
Resolves all 3 open HIGH Dependabot alerts, all rooted in the transitive github.com/docker/docker dependency (legacy +incompatible module path): - GHSA-rg2x-37c3-w2rh docker cp race -> bind-mount redirection to host (<= 28.5.2, no legacy patch) - GHSA-x86f-5xw2-fm2r PUT /containers/{id}/archive executes binary on host (<= 28.5.2, no legacy patch) - GHSA-x744-4wpc-v9h2 Moby AuthZ plugin bypass on oversized request bodies (patched 29.3.1) docker/docker was pulled in only through the `tool` directive github.com/bufbuild/buf/cmd/buf (protobuf codegen) and is never linked into the signing library (govulncheck: no reachable vulnerabilities). The legacy github.com/docker/docker module path tops out at v28.5.2 and cannot reach the patched 29.x line, because Docker moved 29.x to the github.com/moby/moby path. buf v1.70.0 migrated off docker/docker to github.com/moby/moby/api and .../client, removing the vulnerable module from the graph entirely. No source changes; only go.mod/go.sum. The `go` directive moves 1.25.0 -> 1.25.10 (buf v1.70.0 minimum), still under the existing toolchain go1.25.11. Verified: go build ./... and `make test_ci` (go test -race, 60m timeout, fresh keygen/resharing fixtures) both pass; govulncheck reports no vulnerabilities. Generated by Claude Code Agent
|
Warning Review limit reached
More reviews will be available in 30 minutes and 38 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
fabian-dios
left a comment
There was a problem hiding this comment.
Approved — verified this PR contains only dependency changes (go.mod/go.sum) remediating the cited Dependabot advisories, with no source-code modifications.
Summary
Resolves all 3 open HIGH Dependabot alerts. Before -> after: 3 high -> 0 high, 0 critical (unchanged), 0 moderate/low (none open).
All three alerts are rooted in the transitive
github.com/docker/dockerdependency, which is pulled in only through thetooldirectivegithub.com/bufbuild/buf/cmd/buf(protobuf codegen) — it is never linked into the threshold-signature library.govulncheckconfirms zero reachable vulnerabilities both before and after.docker cprace → bind-mount redirection to host path<= 28.5.2, no patch on legacy pathPUT /containers/{id}/archiveexecutes container binary on host<= 28.5.2, no patch on legacy path29.3.1Why a
bufbump (not adocker/dockerbump)The legacy
github.com/docker/docker+incompatiblemodule path tops out at v28.5.2 — the fixed29.xline was published only on the newgithub.com/moby/mobymodule path, so the vulnerable module cannot be patched in place.buf v1.56.0still depended ondocker/docker;buf v1.70.0migrated togithub.com/moby/moby/api+.../client, removinggithub.com/docker/docker(anddocker/cli,docker/distribution) from the module graph entirely.Changes
github.com/bufbuild/bufv1.56.0→v1.70.0(indirect, tool directive) and its transitive deps.github.com/docker/dockerremoved fromgo.mod/go.sum(0 references remaining).godirective1.25.0→1.25.10(buf v1.70.0 minimum), under the existingtoolchain go1.25.11.go.mod/go.sumonly. No cryptographic behavior is touched.Breaking changes
None for consumers of this library. The only direct-dependency surface change is the
godirective minimum (1.25.0→1.25.10); all changes are build-time/tooling-only (bufcodegen path) anddocker/dockerwas never in the import graph of the signing code.Verification
go build ./...— passesmake test_ci(go test -failfast -race -timeout 60m, fresh keygen/resharing fixtures regenerated) — all packages pass, no data racesgovulncheck ./...— "No vulnerabilities found"Generated by Claude Code Agent