Repository navigation
Conversation
8 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When automatic redirects are enabled, a 302 response with an empty or whitespace-only
Locationheader loses its response body. The Linux backend marks it as an intermediate redirect and discards the bytes, although curl ignores the empty destination and returns that response.Only a nonblank Location value now marks a response as a redirect. Add loopback regressions that preserve status 302 and the
no destinationbody for empty and whitespace-only values. Existing valid redirect coverage remains. This follows the pinned curl header handling in lib/http.c; console redirect semantics remain unmeasured.Tested
The added regression fails before the production change with
empty redirect discarded response body; both cases pass after it. Full bundled Linux Release integration build on upstreamee4962190, commit845f711a5; seven selected checks pass without skips, including the network suite, offline HTTP/HTTP2, response headers, SSL, patched libraries and pad. The new condition and regression cases match the tested integration. The integration also includes the separate partial-body fix from fork PR #16 and other development changes; that fix is not included in this topic. Topic and integration conventions pass. Windows and an independent full topic build have not been run. No title progression or new guest exports are claimed.This is a review PR in the JJenkx fork. The upstream author quota is occupied by boykopovar#4474. It is based on the Linux transport branch so the diff contains only this follow-up.
Checklist
October 13 upstream update
Updated against upstream
9d0a41d5a10and the transport parent's new head2ec383a8c6; the published head isc58d9c0b69. It merges cleanly with its transport parent and newer upstream0214069e33c(the intervening upstream change only updates the build workflow). Local conventions pass against the updated parent. The validation reported above applies to its original tested revision.This PR deliberately targets
feat/linux-http-transportto keep its follow-up diff separate. The repository's manual full-build workflow only accepts PRs targetingmain, so its inapplicable dispatch was cancelled. Targeted validation of this updated head is reported below.Targeted validation of published head
c58d9c0b69: Linux Release with bundled pinned dependencies;guest_http_tests,guest_http_response_header_testsandguest_http_network_testsbuild successfully. All three corresponding CTest checks pass without skips, including the local HTTP/HTTPS transport regression fixture. Each parent/follow-up branch was checked out and rebuilt separately in the same isolated validation worktree; these are individual branch results. This is a targeted Linux build, not full Windows or full-suite validation.