Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The new
guest_module_dirhost fixture in upstream #6106 is built as a synthetic ELF withoutPT_GNU_STACK. On this Linux host, the loader treats it as requesting an executable stack and refuses to loadlibOptional.prx, so the test fails before checking the intended dependency behavior. This follow-up appends aPT_GNU_STACKheader with read/write flags and increments the ELF program-header count. It changes only the test fixture; production relinker code is unchanged.This draft branch contains boykopovar#6106's current project-source commit, preserving Zinebyte's authorship, followed by my two-line fixture commit. Depends on: boykopovar#6106. The fixture commit should be taken after boykopovar#6106 or incorporated into it; the branch is not an independent implementation of its dependency change.
Tested
Linux x86-64, current main
d92a8dad390af1807cc91622b924252141816a5a, Release relinker-only build. With boykopovar#6106 head78b906fb67a8edff3969f60d26ced129f981139ealone,guest_module_dirfails deterministically becausectypes.CDLLreportslibOptional.prx: cannot enable executable stack as shared object requires: Invalid argument. With only this fixture correction added, 172/172 CTests pass, includingguest_module_dir(0.28 s). Conventions and whitespace checks pass.I also composed the current boykopovar#6106 change with #5559 on the same main. Without this correction, 172/173 relinker tests pass and
guest_module_dirfails with the same loader error; with it, 173/173 pass, includingguest_deferred_dependencies. These are local relinker-only checks; a full project build and other hosts remain unverified.Checklist