Repository navigation
Retry should_catch_marten_command_exceptions like its sibling - #5789
Merged
Merged
Conversation
Bug_catching_up_command_errors.should_catch_marten_command_exceptions is the same intermittent as Bug_catching_up_apply_errors.should_catch_apply_event_exceptions (same shape, same "should throw AggregateException but did not"), but it had no Retry trait, so one miss turned PR 5780's Daemon (net10, PGlatest, STJ) job red for a change that cannot reach it. A pass on a retry is still reported as FLAKY in the retry ledger and job summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug_catching_up_command_errors.should_catch_marten_command_exceptionsis the same intermittent as its sibling in the same file,Bug_catching_up_apply_errors.should_catch_apply_event_exceptions. It has the same shape and fails with the same "Task should throw System.AggregateException but did not".The sibling already carries
[Trait("Retry", "3")], and its comment records its first attempt failing in 13 of 33 green master runs. This one had no trait. Retries have been opt-in under the supervisor since #5687, so one miss turned PR 5780'sDaemon (net10, PGlatest, STJ)job red, even though that change cannot reach this test: it is gated to subclass LINQ queries, andFailsOnSavehas no subclasses.A pass on a retry is still reported as FLAKY in the retry ledger and the job summary, so this doesn't hide the intermittent. The underlying lead is unchanged:
CatchUpAsynccan return before a faulted shard's exception is observable.Verified locally:
--filter-trait "Retry=3"selects the test (so the trait is applied), and it passes on net10.0.🤖 Generated with Claude Code