Repository navigation
Publish NuGet packages through trusted publishing - #5340
Merged
Merged
Conversation
publish_nugets.yml now gets its nuget.org key from NuGet/login, which trades the run's GitHub OIDC token for a short-lived API key under the trusted publishing policy already set up on nuget.org, instead of the long-lived NUGET_API_KEY secret. Same shape as JasperFx's manual publish workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish_nugets.ymlnow authenticates to nuget.org with trusted publishing instead of the long-livedNUGET_API_KEYsecret.NuGet/login@v1step (user: jeremydmiller) trades the run's GitHub OIDC token for a short-lived API key under the trusted publishing policy already configured on nuget.org for this repository and this workflow file.permissions: contents: read, id-token: write;id-token: writeis what lets the runner request the OIDC token.steps.nuget_login.outputs.NUGET_API_KEYthrough an env var.Same shape as JasperFx's
on-manual-do-nuget-publish.yml. The policy names the workflow file, so renamingpublish_nugets.ymlbreaks it until the policy is edited on nuget.org.Not touched:
dotnet.yml's "Publish Release Packages" step still referencesNUGET_API_KEY, but it only runs onrefs/tags/v*and that workflow never triggers on tags, so it is dead code.This can only be proven by the real run, i.e. the 6.61.0 publish.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U