Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5306
What changed
KafkaReplayRequest.GroupIdoptionally sets the replay consumer's group id verbatim. This lets deployments with literal group ACLs authorize a replay explicitly. When the property is omitted or blank, Wolverine keeps its existing generated replay group id.The replay consumer remains assign-only and does not commit offsets.
Validation
dotnet test src/Transports/Kafka/Wolverine.Kafka.Tests/Wolverine.Kafka.Tests.csproj --filter FullyQualifiedName~replay_uses_a_requested_group_id_verbatimpassed (1 test).