Added support for animated items to the map#170
Open
Rhoenicx wants to merge 2 commits into
Open
Conversation
JavidPack
reviewed
Jul 25, 2026
|
|
||
| // Support for item animations. | ||
| if (ItemID.Sets.AnimatesAsSoul[item.type]) { | ||
| Rectangle itemFrame = Main.itemAnimations[item.type].GetFrame(itemTexture); |
Owner
There was a problem hiding this comment.
I think these should just be Rectangle itemFrame = Main.itemAnimations[item.type]?.GetFrame(itemTexture) ?? itemTexture.Frame();. An item with an animation doesn't necessarily set ItemID.Sets.AnimatesAsSoul
Author
There was a problem hiding this comment.
You are right, this is the proper solution. I was convinced ItemID.Sets.AnimatesAsSoul was needed for the item animation. I see Terraria gets the frame the same way like you suggested. I'll make an update.
Changed the draw code based on the suggestion of JavidPack: replaced ItemID.Sets.AnimatesAsSoul with Main.GetItemDrawFrame. Also added safeguards against dividing by zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players of Gensokyo mod reported that the item animations of the bossbags were not displayed correctly on the minimap. The entire spritesheet is visible instead of the frame specified inside the ItemAnimation class. Added compatibility for ItemAnimations.