Repository navigation
Conversation
…ayBuildRequestEnabled Replace the NotImplemented placeholders with the offline option setters of sceHttpCacheRedirectedConnectionEnabled: BEFORE_INIT without a live context, INVALID_ID for an unknown object, 0 for a live template, connection or request. The unverified behaviour is recorded in the libSceHttp debt file.
Progress report (66e1f7f → d120593)📈 System libraries: 26.3% (+0.01%, +2 implemented functions) ✅ 2 implemented
Changed libraries (implemented exports)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements
sceHttpSetHttp09EnabledandsceHttpSetDelayBuildRequestEnabled(libSceHttp NIDspk0AuomQM1oand22buO-UufJY), which threwNotImplemented_nid_no_patch. They followsceHttpCacheRedirectedConnectionEnabledinsrc/Options.cpp:ERROR_BEFORE_INIT(0x80431001) while nosceHttpInitcontext is alive,ERROR_INVALID_ID(0x80431100) for an id that is not a live template, connection or request, otherwise 0. The value is accepted as given and not kept: no request reaches the network, so HTTP/0.9 response parsing and delayed request building change nothing, and no getter reads them back. The declarations stay as they were inHttp.hpp, with the parameter renamed toenable.The behaviour is not measured on a PS5. The signature
(int id, int enable)follows shadPS4, which only logs and returns 0; the order of the checks follows the neighbouring option calls, and whether the console refuses values above 1 assceHttpSetCookieEnableddoes is unverified.docs/dev/debt/libSceHttp.mdgets a silent-stub entry that states this. The libSceHttp debt file keeps no export count, so there is no count to change.guest_http_optionsis extended: both setters accept a template, a connection and a request with 0, 1, -1 and 7, refuse an unknown id and id 0 withERROR_INVALID_ID, and returnERROR_BEFORE_INITafter the lastsceHttpTerm.Tested
Linux x86_64, GCC 14.2 (g++ extracted from Debian trixie packages),
-DBUILD_TESTING=ON, full configure with all submodules. Hardware and titles: not tested.libSceHttpandguest_http_options_tests;ctestpassesguest_http,guest_http_response_headerandguest_http_options(the last in under 0.1 s);guest_http_uri_localeis skipped as onmain.core/libs/tests/test_public_headers.py --audit-onlypasses (one declaration per export).tools/check_conventions.py --base origin/mainandtools/check_test_registration.pypass.tools/pr_overlap.py --branch feat/http-option-settersfinds no PR with the same exports or new files. It reports textual overlap indocs/dev/debt/libSceHttp.mdwith feat(libSceHttp): add synchronous HTTP request transport boykopovar/AnyPS5#9834 and fix(http): trust the system CA list for HTTPS requests boykopovar/AnyPS5#11134 (the HTTP request transport), and could not compare that file with docs(debt): separate entries with blank lines and drop derived export totals boykopovar/AnyPS5#14212 (a docs-wide debt reformat that conflicts withmain); none of the three changes these two exports.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)