fix: active session not clearing on tab close (Mac/Windows) - #3952
Open
SomeshG1151 wants to merge 1 commit into
Open
fix: active session not clearing on tab close (Mac/Windows)#3952SomeshG1151 wants to merge 1 commit into
SomeshG1151 wants to merge 1 commit into
Conversation
…on Mac/Windows - beforeunload beacon is dropped by Chrome on Mac/Windows before reaching server - pagehide fires reliably on tab close and navigation on all platforms - fixed removeEventListener bug (was passing new anonymous fn, never actually removed) - re-enabled active_project check in views.py with typo fix Fixes JdeRobot#3510
Member
|
Missing video evidence of the fix working on Chrome and Firefox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3510
Root cause:
beforeunloadfetch/beacon is dropped by Chrome on Mac/Windowsbefore reaching the server, leaving active_project set permanently.
Changes:
Project.tsx: replacedbeforeunloadwithpagehidewhich fires reliablyon all platforms including Mac/Windows on tab close and navigation
Project.tsx: fixedremoveEventListenerbug — was passing a new anonymousfunction each time so the listener was never actually removed
views.py: re-enabled the active_project session check that was temporarilydisabled in Disable active project check for now #3514, now that cleanup is reliable
views.py: fixed typo "Alredy" → "Already"