Repository navigation
Sp500 tolerance - #40
Merged
Merged
Conversation
- test_real_data: allow 1e-9 for the QP gap on S&P downloads other than the note's snapshot (1e-10 on the snapshot, as before). On the October 2026 download the QP missed one corner by 3.4e-10 while the path's KKT residual stayed below 4e-12, so a reproducer's fresh download failed a test on the baseline, not the path. The note says so. - keywords under the abstract (the journal asks for 4-6) - DOIs for 18 of the 21 references, each checked against Crossref, CRAN or arXiv. All 21 references were checked: authors, title, venue, volume, issue, pages and year match their source. JMLR (scikit-learn), the Data Library and the 1974 Lawson-Hanson book have no DOI. All 14 tests pass with both data sets; the arXiv source compiles (9 pages, no overfull lines). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A clean-clone reproduction (fresh uv cache, uv run --locked, both data sets downloaded) compared every S&P corner rather than every 10th, and on that download the QP baseline missed by up to 8.8e-10: inside the 1e-9 tolerance, but with little margin. The path's own KKT residual was 3.0e-12. Allow 1e-8 on data that are not the snapshot (1e-10 on it, as before), and say in the note that the QP drifts by up to 9e-10 and what the tests allow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.