Skip to content

Fix uninitialized CUB reduction identity corrupting fill_holes vertices #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rwfsmith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix uninitialized CUB reduction identity corrupting fill_holes vertices #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/dtypes.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ namespace cumesh {
struct __align__(16) Vec3f {
float x, y, z;

__device__ __forceinline__ Vec3f();
__device__ __forceinline__ Vec3f(float x, float y, float z);
__device__ __forceinline__ Vec3f(float3 v);
__host__ __device__ __forceinline__ Vec3f();
__host__ __device__ __forceinline__ Vec3f(float x, float y, float z);
__host__ __device__ __forceinline__ Vec3f(float3 v);
__device__ __forceinline__ Vec3f operator+(const Vec3f& o) const;
__device__ __forceinline__ Vec3f& operator+=(const Vec3f& o);
__device__ __forceinline__ Vec3f operator-(const Vec3f& o) const;
Expand Down Expand Up @@ -55,19 +55,19 @@ struct __align__(16) QEM
};


__device__ __forceinline__ Vec3f::Vec3f() {
__host__ __device__ __forceinline__ Vec3f::Vec3f() {
x = 0.0f;
y = 0.0f;
z = 0.0f;
}

__device__ __forceinline__ Vec3f::Vec3f(float x, float y, float z) {
__host__ __device__ __forceinline__ Vec3f::Vec3f(float x, float y, float z) {
this->x = x;
this->y = y;
this->z = z;
}

__device__ __forceinline__ Vec3f::Vec3f(float3 v) {
__host__ __device__ __forceinline__ Vec3f::Vec3f(float3 v) {
x = v.x;
y = v.y;
z = v.z;
Expand Down