fix: EXPOSED-644 Can't use Instant.DISTANT_FUTURE as default value#2832
Open
Chantal Loncle (bog-walk) wants to merge 1 commit into
Open
fix: EXPOSED-644 Can't use Instant.DISTANT_FUTURE as default value#2832Chantal Loncle (bog-walk) wants to merge 1 commit into
Chantal Loncle (bog-walk) wants to merge 1 commit into
Conversation
Instant.DISTANT_FUTURE is represented as a very large value that starts with '+'. Most databases are unable to parse this type of string or incorrectly assume following values are part of timezone, leading to syntax errors. This fix ensures any '+' character is trimmed before being passed as default value or in statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
timestamp()columns now handleInstant.DISTANT_FUTUREpassed as default value for databases that allow storing very large datetime values.Detailed description:
Why:
Instant.DISTANT_FUTUREis represented as a very large value that starts with '+' ->+100000-01-01T00:00:00Z. The databases that allow storing a value greater than 9999 are either unable to parse this type of string or incorrectly assume the value following '+' is part of a timezone, leading to syntax errors.What: Basic
.format()is replaced by a version that also trims unneeded '+' fromLocalDateTime. Databases that don't allow large values continue to fail with "value out-of-range" errors, while databases that do allow large values, now accepts and returns this constant.Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED_644