Support AutoFill login and password - #3335
Open
Andrei Salavei (ASalavei) wants to merge 2 commits into
Open
Conversation
Andrei Salavei (ASalavei)
force-pushed
the
andrei.salavei/autofill
branch
from
August 31, 2026 15:52
56ffe15 to
9822636
Compare
Support "Save Password" when the username and password views are both in the hierarchy at once. - Introduce `TextInputContainer` (a per-scene factory) with a nested `TextInputContainer.Holder` that creates and controls the state and position of the native text input view for every text field in the Compose scene, including unfocused ones. The scene now creates the input view as soon as the corresponding text field appears on screen, and that view becomes the first responder to handle native keyboard input. - Rework `ProvideNewContextMenuDefaultProviders` in `ContextMenu.ios.kt`: it now reuses the corresponding native input views added by `TextInputContainer`. - `ComposeTextInputConnection` and `NativeTextInputConnection` can now work with both active and inactive text input delegates. - Add `PlatformTextInputMethodRequest.editorToken` to connect an editing request with the corresponding native text input view. - Update `CMPEditMenuView` and `CMPTextInputView` to conform to the `UITextField` interface when secure text input is enabled.
Andrei Salavei (ASalavei)
force-pushed
the
andrei.salavei/autofill
branch
from
August 31, 2026 15:53
9822636 to
c26c372
Compare
Alexander Maryanovsky (m-sasha)
approved these changes
Aug 31, 2026
Alexander Maryanovsky (m-sasha)
left a comment
Alexander Maryanovsky (m-sasha)
left a comment
There was a problem hiding this comment.
Looks good from skiko and desktop point of view.
Andrei Salavei (ASalavei)
marked this pull request as ready for review
August 31, 2026 17:41
Andrei Salavei (ASalavei)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support "Save Password" when the username and password views are both in the hierarchy at once.
TextInputContainer(a per-scene factory) with a nestedTextInputContainer.Holderthat creates and controls the state and position of the native text input view for every text field in the Compose scene, including unfocused ones. The scene now creates the input view as soon as the corresponding text field appears on screen, and that view becomes the first responder to handle native keyboard input.ProvideNewContextMenuDefaultProvidersinContextMenu.ios.kt: it now reuses the corresponding native input views added byTextInputContainer.ComposeTextInputConnectionandNativeTextInputConnectioncan now work with both active and inactive text input delegates.PlatformTextInputMethodRequest.editorTokento connect an editing request with the corresponding native text input view.CMPEditMenuViewandCMPTextInputViewto conform to theUITextFieldinterface when secure text input is enabled.Fixes: https://youtrack.jetbrains.com/issue/CMP-5802/Support-Auto-save-and-auto-update-password-prompts-on-iOS.
Release Notes
Features - iOS