Adds support for UiMediaScope in iOS - #3340
Open
Apolo (ApoloApps) wants to merge 11 commits into
Open
Conversation
This was referenced Aug 25, 2026
Author
Vendula Švastalová (svastven)
requested review from
Andrei Salavei (ASalavei) and
Vendula Švastalová (svastven)
August 26, 2026 12:04
| ) | ||
| private val systemThemeState: MutableState<SystemTheme> = mutableStateOf(SystemTheme.UNKNOWN) | ||
|
|
||
| private val systemDensityState: MutableState<Density> = mutableStateOf(window?.density ?: Density(1f)) |
There was a problem hiding this comment.
There is screenDensity currently in WindowContext. These two should be consolidated as they represent the same value dependent on the current window.
Author
There was a problem hiding this comment.
Done! Removed the one from MediaEnvironment as it it unused and leftover from previous pr
|
|
||
| val systemTheme: SystemTheme | ||
| get() = systemThemeState.value | ||
| val systemDensity: Density |
There was a problem hiding this comment.
I am not sure this value belongs here. IMO better to keep it in WindowContext as it is tied to window.
I see that it is not required by the UiMediaScope interface.
Author
There was a problem hiding this comment.
what are you referring to here? the system theme or density? The latter has been removed since it did not have usages
…MediaEnvironment.ios.kt Co-authored-by: Andrei Salavei <Andrei.Salavei@jetbrains.com>
Ivan Matkov (MatkovIvan)
pushed a commit
that referenced
this pull request
Sep 1, 2026
Smaller change to support UiMediaScope in skiko platforms Fixes [CMP-10481](https://youtrack.jetbrains.com/issue/CMP-10481/Add-Support-for-UiMediaScope) (common part) iOS PR: #3340 Desktop PR: #3341 ## Release Notes ### Features - Multiple Platforms - Add support for mediaQuery calls which allows to modify Composables depending on device characteristics
…e/ui/platform/CompositionLocals.skiko.kt
… all iOS related tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #3339
Merge after mentioned PR is merged (iOS changes only, skiko logic is handled in said PR)
Fixes https://youtrack.jetbrains.com/issue/CMP-10740/iOS-Report-real-device-characteristics-to-mediaQuery
Release Notes
N/A