Adds support for UiMediaScope in Desktop - #3341
Open
Apolo (ApoloApps) wants to merge 7 commits into
Open
Conversation
This was referenced Aug 25, 2026
Author
Alexander Maryanovsky (m-sasha)
approved these changes
Aug 26, 2026
Comment on lines
+30
to
+34
| override val windowWidth: Dp | ||
| get() = windowInfo.containerDpSize.width | ||
|
|
||
| override val windowHeight: Dp | ||
| get() = windowInfo.containerDpSize.height |
There was a problem hiding this comment.
Maybe not important, but windowInfo.containerDpSize refers to the container (excludes insets), and this refers to the window (includes insets).
Author
There was a problem hiding this comment.
Ivan Matkov (MatkovIvan)
pushed a commit
that referenced
this pull request
Sep 1, 2026
Smaller change to support UiMediaScope in skiko platforms Fixes [CMP-10481](https://youtrack.jetbrains.com/issue/CMP-10481/Add-Support-for-UiMediaScope) (common part) iOS PR: #3340 Desktop PR: #3341 ## Release Notes ### Features - Multiple Platforms - Add support for mediaQuery calls which allows to modify Composables depending on device characteristics
…e/ui/platform/CompositionLocals.skiko.kt
Alexander Maryanovsky (m-sasha)
approved these changes
Sep 2, 2026
Alexander Maryanovsky (m-sasha)
requested a review
from Ivan Matkov (MatkovIvan)
September 2, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #3339
Merge after mentioned PR is merged (desktop changes only, skiko logic is handled in said PR)
Fixes https://youtrack.jetbrains.com/issue/CMP-10741/Desktop-Report-real-device-characteristics-to-mediaQuery
Release Notes
N/A