Fix iOS word selection for CJK text - #3377
Open
Kyle (Kyle-Ye) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS, double-tap word selection uses Compose's layout word boundary, which can treat each
CJK ideograph as a separate word. This differs from UIKit's linguistic word selection.
This change:
NLTokenizerTextLayoutResult.getWordBoundarywhen the platform tokenizer returns no word,preserving the existing behavior for whitespace and unsupported text
Fixes https://youtrack.jetbrains.com/issue/CMP-10706
Platform scope
The common source-set change only widens the visibility of the existing
BoundaryFunctionandadjustToBoundarieshelpers fromprivatetointernal, allowing the iOS source set to reuse theestablished boundary-adjustment logic.
No common selection semantics are changed. The
NLTokenizer-backed adjustment is injected andconsumed only by the iOS text-field paths. Other Skiko platforms continue using the existing
SelectionAdjustment.Wordbehavior.Design rationale
An alternative would be to change
TextLayoutResult.getWordBoundaryso that it returnsNLTokenizerboundaries on iOS. This was intentionally not chosen becauseTextLayoutResult.getWordBoundaryis a public text-layout API whose contract is based on Unicodeword boundaries. It is also used by behavior beyond repeated-tap TextField selection, including
general text selection, word navigation and deletion, selection containers, and native text-input
integration.
Changing that API would therefore alter word-boundary semantics across a substantially broader
surface. It would also require introducing a platform-specific boundary provider below the shared
non-Android Skiko paragraph implementation. This change instead keeps the existing layout boundary
contract intact and applies UIKit-compatible linguistic tokenization only to the iOS TextField
interaction that requires it.
Testing
AI assistance disclosure
This contribution was developed with AI assistance. The implementation, tests, and behavior were
reviewed, corrected, and validated by the author.