Skip to content

fix: code quality and safety improvements #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: code quality and safety improvements #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/Home/components/VisitorBadge.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function OdometerDisplay({ value }) {
,
</span>
) : (
<Reel key={i} digit={parseInt(char)} />
<Reel key={i} digit={parseInt(char, 10)} />
)
)}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/PageNumbers/PageNumbers.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export function PageNumbers() {
value={startNumber}
min={0}
max={9999}
onChange={(e) => setStartNumber(Math.max(0, parseInt(e.target.value) || 0))}
onChange={(e) => setStartNumber(Math.max(0, parseInt(e.target.value, 10) || 0))}
className="w-full h-11 px-4 bg-zinc-900/60 border border-white/10 rounded-xl text-sm text-white focus:outline-none focus:border-white/30 transition-colors"
/>
</div>
Expand Down
8 changes: 4 additions & 4 deletions src/pages/Watermark/Watermark.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export function Watermark() {
{watermarkMode === "text" && (
<div className="space-y-2">
<label className="text-xs text-zinc-500 uppercase">Size: {options.fontSize}px</label>
<input type="range" min="10" max="200" value={options.fontSize} onChange={(e) => updateOption("fontSize", parseInt(e.target.value))} className="w-full h-1.5 bg-zinc-800 rounded-lg appearance-none cursor-pointer accent-white" />
<input type="range" min="10" max="200" value={options.fontSize} onChange={(e) => updateOption("fontSize", parseInt(e.target.value, 10))} className="w-full h-1.5 bg-zinc-800 rounded-lg appearance-none cursor-pointer accent-white" />
</div>
)}
{watermarkMode === "image" && (
Expand All @@ -278,7 +278,7 @@ export function Watermark() {

<div className="space-y-2">
<label className="text-xs text-zinc-500 uppercase">Rotation: {options.rotation}°</label>
<input type="range" min="-90" max="90" value={options.rotation} onChange={(e) => updateOption("rotation", parseInt(e.target.value))} className="w-full h-1.5 bg-zinc-800 rounded-lg appearance-none cursor-pointer accent-white" />
<input type="range" min="-90" max="90" value={options.rotation} onChange={(e) => updateOption("rotation", parseInt(e.target.value, 10))} className="w-full h-1.5 bg-zinc-800 rounded-lg appearance-none cursor-pointer accent-white" />
</div>

<div className="grid grid-cols-2 gap-4">
Expand All @@ -287,7 +287,7 @@ export function Watermark() {
<input
type="number"
value={options.offsetX}
onChange={(e) => updateOption("offsetX", parseInt(e.target.value) || 0)}
onChange={(e) => updateOption("offsetX", parseInt(e.target.value, 10) || 0)}
className="w-full h-10 px-3 bg-black border border-white/10 text-white rounded-lg outline-none focus:ring-1 focus:ring-white/20"
/>
</div>
Expand All @@ -296,7 +296,7 @@ export function Watermark() {
<input
type="number"
value={options.offsetY}
onChange={(e) => updateOption("offsetY", parseInt(e.target.value) || 0)}
onChange={(e) => updateOption("offsetY", parseInt(e.target.value, 10) || 0)}
className="w-full h-10 px-3 bg-black border border-white/10 text-white rounded-lg outline-none focus:ring-1 focus:ring-white/20"
/>
</div>
Expand Down