fix: add missing footer i18n keys for support, guidelines, and faq - #7287
Conversation
|
@Goutam-2702 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
|
@JhaSourav07 pls review and merge it to main. |
Aamod007
left a comment
There was a problem hiding this comment.
Hey! Thanks for your contribution. Unfortunately, it looks like this PR is currently blocked (e.g., failing CI checks, merge conflicts, or marked as draft). I can't review or approve it until the build is green. Please resolve these issues so we can proceed with a full review! Let me know if you need any help debugging.
|
@Aamod007 pls review and merge my pr all problem of ci pipeline are resolved. |
Aamod007
left a comment
There was a problem hiding this comment.
Hey! Thanks for fixing the missing footer i18n keys for support, guidelines, and FAQ. This is really helpful for our localization efforts.
I'm assigning level:beginner for these straightforward string additions, type:bug, and quality:clean.
Unfortunately, it looks like the Vercel CI check is still failing and blocking this PR. Please investigate the Vercel build logs, resolve the issues, and push an update. Let me know once it's passing so we can merge this!
|
@Aamod007 pls review and merge my pr all problem of ci pipeline are resolved. |
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing: We are ignoring the Vercel/CI failures as per the latest update. Your code changes look solid. Approving!
3bfd714 to
0a7c55b
Compare
|
🚨 Hey @Goutam-2702, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
|
@Aamod007 |
Aamod007
left a comment
There was a problem hiding this comment.
Thank you for fixing the missing footer i18n keys! Ensuring our translation dictionaries are complete is crucial for maintaining our internationalization support. I noticed that the main \Format · Lint · Typecheck · Test\ CI pipeline has failed. I have triggered a rerun of the CI to see if the issue was intermittent. If it continues to fail, please verify the translation keys locally and update this PR!
Labels assigned:
- \level:beginner: Adding missing string constants.
- \ ype:bug: Fixes missing translations.
|
@Aamod007 pls review and merge it. |
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamod007
left a comment
There was a problem hiding this comment.
Adding the missing footer i18n keys for support, guidelines, and faq fixes the un-translated strings nicely. However, the CI checks are failing. Please resolve the issues and rerun the CI pipeline.
Aamod007
left a comment
There was a problem hiding this comment.
Upon re-evaluation, I realized I previously misinterpreted the Vercel deployment failure as an issue with this PR. The Vercel build failure seems unrelated to the changes introduced here, so I will ignore it moving forward. The rest of the PR looks good, so I'm approving it!
|
🎉 Congratulations @Goutam-2702! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #7284
Added the missing translation keys (
support,guidelines,faq) to thefooterobject across all i18n locale JSON files (en.json,de.json,es.json,fr.json,hi.json,ja.json,ko.json,pt.json,zh.json). This resolves the issue where raw key names were leaking in the production footer.Pillar
Visual Preview
N/A
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.