Skip to content

fix: add missing footer i18n keys for support, guidelines, and faq - #7287

Merged
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
Goutam-2702:fix-7284-footer-i18n
Jul 17, 2026
Merged

fix: add missing footer i18n keys for support, guidelines, and faq#7287
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
Goutam-2702:fix-7284-footer-i18n

Conversation

@Goutam-2702

Copy link
Copy Markdown
Contributor

Description

Fixes #7284

Added the missing translation keys (support, guidelines, faq) to the footer object across all i18n locale JSON files (en.json, de.json, es.json, fr.json, hi.json, ja.json, ko.json, pt.json, zh.json). This resolves the issue where raw key names were leaking in the production footer.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • ⚡ Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@Goutam-2702 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/6247-[hash].js 34.44 KB 34.21 KB +0.23 KB (+0.67%) 🔴 Regression

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3910.17 KB 3909.55 KB +0.62 KB (+0.02%)
Total CSS 324.75 KB 324.75 KB 0 B

@Goutam-2702

Copy link
Copy Markdown
Contributor Author

@JhaSourav07 pls review and merge it to main.

@Aamod007 Aamod007 added mentor:Aamod007 level:beginner Small changes Usually isolated fixes or simple UI/text updates. type:bug Something isn't working as expected labels Jul 2, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for your contribution. Unfortunately, it looks like this PR is currently blocked (e.g., failing CI checks, merge conflicts, or marked as draft). I can't review or approve it until the build is green. Please resolve these issues so we can proceed with a full review! Let me know if you need any help debugging.

@github-actions github-actions Bot added status:blocked This PR is blocked due to a failing CI check. and removed status:blocked This PR is blocked due to a failing CI check. labels Jul 2, 2026
@Goutam-2702

Copy link
Copy Markdown
Contributor Author

@Aamod007 pls review and merge my pr all problem of ci pipeline are resolved.

@Goutam-2702
Goutam-2702 requested a review from Aamod007 July 3, 2026 13:59
@Aamod007 Aamod007 added the quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. label Jul 4, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for fixing the missing footer i18n keys for support, guidelines, and FAQ. This is really helpful for our localization efforts.

I'm assigning level:beginner for these straightforward string additions, type:bug, and quality:clean.

Unfortunately, it looks like the Vercel CI check is still failing and blocking this PR. Please investigate the Vercel build logs, resolve the issues, and push an update. Let me know once it's passing so we can merge this!

@Goutam-2702

Copy link
Copy Markdown
Contributor Author

@Aamod007 pls review and merge my pr all problem of ci pipeline are resolved.

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewing: We are ignoring the Vercel/CI failures as per the latest update. Your code changes look solid. Approving!

@Goutam-2702
Goutam-2702 force-pushed the fix-7284-footer-i18n branch from 3bfd714 to 0a7c55b Compare July 8, 2026 16:13
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🚨 Hey @Goutam-2702, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Goutam-2702

Copy link
Copy Markdown
Contributor Author

@Aamod007
ci pipeline fail can u merge it

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the missing footer i18n keys! Ensuring our translation dictionaries are complete is crucial for maintaining our internationalization support. I noticed that the main \Format · Lint · Typecheck · Test\ CI pipeline has failed. I have triggered a rerun of the CI to see if the issue was intermittent. If it continues to fail, please verify the translation keys locally and update this PR!

Labels assigned:

  • \level:beginner: Adding missing string constants.
  • \ ype:bug: Fixes missing translations.

@Goutam-2702
Goutam-2702 requested a review from Aamod007 July 11, 2026 07:21
@Goutam-2702

Copy link
Copy Markdown
Contributor Author

@Aamod007 pls review and merge it.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Hey @Goutam-2702, this pull request has been inactive for 4 days. It will be automatically closed in 1 days if no further activity occurs.

If you are still working on this, please push your latest changes or leave a comment to keep it active.

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the missing footer i18n keys for support, guidelines, and faq fixes the un-translated strings nicely. However, the CI checks are failing. Please resolve the issues and rerun the CI pipeline.

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon re-evaluation, I realized I previously misinterpreted the Vercel deployment failure as an issue with this PR. The Vercel build failure seems unrelated to the changes introduced here, so I will ignore it moving forward. The rest of the PR looks good, so I'm approving it!

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jul 17, 2026
@JhaSourav07
JhaSourav07 merged commit 25ec7f3 into JhaSourav07:main Jul 17, 2026
5 of 6 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @Goutam-2702! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points gssoc:needs-rebase level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Broken i18n Translation Keys in the Footer

3 participants