Skip to content

test(AchievementsSkeleton-responsive-breakpoints): verify Responsive … - #7342

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
realtushartyagi:test/7041-achievementsskeleton-responsive-breakpoints
Jul 4, 2026
Merged

test(AchievementsSkeleton-responsive-breakpoints): verify Responsive …#7342
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
realtushartyagi:test/7041-achievementsskeleton-responsive-breakpoints

Conversation

@realtushartyagi

Copy link
Copy Markdown
Contributor

Description

Resolves #7041

This PR introduces comprehensive unit tests for components/dashboard/AchievementsSkeleton.tsx to verify Responsive Multi-device Columns & Mobile Viewport Layouts (Variation 7).

Specifically, this test file (AchievementsSkeleton.responsive-breakpoints.test.tsx) verifies:

  1. Standard mobile-width media coordinates (375px viewport) are correctly mocked and the achievement skeleton renders all 4 cells without errors.
  2. The 2-column grid layout (grid-cols-2) is correctly declared and all 4 skeleton cells remain intact at the mobile base breakpoint.
  3. No inline absolute pixel widths exist that could cause horizontal overflow or scrollbars on smaller viewports.
  4. All shimmer skeleton card tiles are present and carry rounded Tailwind classes, confirming graceful visual scaling on mobile devices.
  5. Mobile-specific toggle states respond cleanly when the viewport transitions from desktop (1440px) to mobile (375px) via a resize event, with the grid and all cells remaining intact.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • ⏱️ Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A - This PR is strictly adding test coverage and does not alter production UI.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • I have run npm run test and all tests pass locally.
  • I have run npm run test:coverage and branch coverage is at or above 70%.
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have starred the repo.
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord server for faster collaboration, mentorship, and PR support.

…Multi-device Columns & Mobile Viewport Layouts (Variation 7) #7041
Copilot AI review requested due to automatic review settings July 3, 2026 12:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@realtushartyagi realtushartyagi left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces the required test coverage for Issue #7041 (AchievementsSkeleton.responsive-breakpoints.test.tsx). The tests simulate real mobile viewport conditions by mocking window.innerWidth and window.matchMedia, then assert the skeleton's 2-column grid layout, the absence of overflow-causing inline widths, graceful shimmer cell scaling, and clean rerender behavior on viewport resize events. All 4 achievement skeleton cells are verified to render correctly at every simulated viewport size. All 5 test cases pass locally with 0 lint errors and 0 type errors. Let me know if you need any adjustments!

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3883.44 KB 3883.44 KB 0 B
Total CSS 323.09 KB 323.09 KB 0 B

@github-actions github-actions Bot added the type:testing Adding, updating, or fixing tests label Jul 4, 2026
@Aamod007 Aamod007 added mentor:Aamod007 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jul 4, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for adding responsive breakpoint tests to AchievementsSkeleton. Guaranteeing mobile viewport rendering and multi-device column layouts don't shift during loading keeps the dashboard looking polished.

I'm assigning level:beginner, type:testing, and quality:clean.

Solid work, approving!

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jul 4, 2026
@JhaSourav07
JhaSourav07 merged commit 97f68da into JhaSourav07:main Jul 4, 2026
8 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🎉 Congratulations @realtushartyagi! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(AchievementsSkeleton-responsive-breakpoints): verify Responsive Multi-device Columns & Mobile Viewport Layouts (Variation 7)

4 participants