test(notify): add TypeScript compiler validation tests - #7353
Merged
JhaSourav07 merged 1 commit intoJul 4, 2026
Merged
Conversation
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
approved these changes
Jul 4, 2026
Aamod007
left a comment
Collaborator
There was a problem hiding this comment.
Hey! Thanks for adding TypeScript compiler validation for the notify route schemas. Testing zod inferred types explicitly stops silent schema drift.
I'm assigning level:beginner, type:testing, and quality:clean.
Looks excellent, approving!
Contributor
|
🎉 Congratulations @Tuba1809! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds TypeScript compiler validation and schema stability tests for the
/api/notifyroute.This PR introduces a dedicated test suite that verifies:
NotifyPostParamsmanagementTokensupportnotifyGetSchemavalidation for valid and invalid usernamesFixes #6772
Pillar
Visual Preview
N/A (test-only changes)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.