feat(themes): add sakura and midnight_ember theme presets for enhanced user experience - #8974
feat(themes): add sakura and midnight_ember theme presets for enhanced user experience#8974nandhanay wants to merge 2 commits into
Conversation
|
@nandhanay is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR adds new theme presets to improve user customization options. It's worth noting that similar past decisions focused on enhancing theme rendering based on user preferences, which significantly improved user experience by addressing issues with theme visibility on first visits. Your contribution aligns well with these efforts. Thank you for your work on this, and I look forward to your updates! |
|
🚨 Hey @nandhanay, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod007
left a comment
There was a problem hiding this comment.
These new themes (\sakura\ and \midnight_ember) look beautiful! However, the main CI pipeline (\Format · Lint · Typecheck · Test) is failing. Please fix the build errors so we can merge these in!
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamod007
left a comment
There was a problem hiding this comment.
These are beautiful additions to our theme catalog! The color palettes for \sakura\ and \midnight_ember\ look well-balanced and complement our existing lineup perfectly. Updating \ hemes.ts, \ hemes.test.ts, and the documentation all together shows great attention to detail.
Labels applied:
- type:design: Adds new visual theme presets for user customization.
- level:beginner: Straightforward dictionary additions and test count updates.
- quality:clean: Simple, accurate, and completely documented.
Description
Fixes #8973
Added
sakuraandmidnight_embertheme presets tothemes.tsand updated theREADME.mdtheme gallery.Pillar
Visual Preview
Added to theme presets array. Will be visible via
?theme=sakuraand?theme=midnight_ember.Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.