Skip to content

feat(themes): add sakura and midnight_ember theme presets for enhanced user experience - #8974

Open
nandhanay wants to merge 2 commits into
JhaSourav07:mainfrom
nandhanay:feat/themes-sakura-midnight
Open

feat(themes): add sakura and midnight_ember theme presets for enhanced user experience#8974
nandhanay wants to merge 2 commits into
JhaSourav07:mainfrom
nandhanay:feat/themes-sakura-midnight

Conversation

@nandhanay

Copy link
Copy Markdown
Contributor

Description

Fixes #8973
Added sakura and midnight_ember theme presets to themes.ts and updated the README.md theme gallery.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Added to theme presets array. Will be visible via ?theme=sakura and ?theme=midnight_ember.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@nandhanay is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@retenta-bot

retenta-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

This PR adds new theme presets to improve user customization options. It's worth noting that similar past decisions focused on enhancing theme rendering based on user preferences, which significantly improved user experience by addressing issues with theme visibility on first visits. Your contribution aligns well with these efforts. Thank you for your work on this, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title feat(themes): add sakura and midnight_ember theme presets feat(themes): add sakura and midnight_ember theme presets for enhanced user experience Aug 8, 2026
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚨 Hey @nandhanay, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. type:feature New features, additions, or enhancements mentor:Aamod007 labels Aug 9, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new themes (\sakura\ and \midnight_ember) look beautiful! However, the main CI pipeline (\Format · Lint · Typecheck · Test) is failing. Please fix the build errors so we can merge these in!

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Hey @nandhanay, this pull request has been inactive for 3 days. It will be automatically closed in 2 days if no further activity occurs.

If you are still working on this, please push your latest changes or leave a comment to keep it active.

@Aamod007 Aamod007 added type:design UI designs, styling, SVG icons, and themes quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Aug 13, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are beautiful additions to our theme catalog! The color palettes for \sakura\ and \midnight_ember\ look well-balanced and complement our existing lineup perfectly. Updating \ hemes.ts, \ hemes.test.ts, and the documentation all together shows great attention to detail.

Labels applied:

  • type:design: Adds new visual theme presets for user customization.
  • level:beginner: Straightforward dictionary additions and test count updates.
  • quality:clean: Simple, accurate, and completely documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:needs-rebase level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check. type:design UI designs, styling, SVG icons, and themes type:feature New features, additions, or enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add sakura and midnight_ember theme presets

3 participants