Skip to content

Fix User Parameter Validation and SVG Error Handling - #9023

Open
armanpanigrahi59 wants to merge 4 commits into
JhaSourav07:mainfrom
armanpanigrahi59:fix/streak-user-validation
Open

Fix User Parameter Validation and SVG Error Handling#9023
armanpanigrahi59 wants to merge 4 commits into
JhaSourav07:mainfrom
armanpanigrahi59:fix/streak-user-validation

Conversation

@armanpanigrahi59

Copy link
Copy Markdown
Contributor

Description

Fixes #870

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@armanpanigrahi59 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@retenta-bot

retenta-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

This PR improves user parameter validation and error handling for SVGs, which is crucial for maintaining a smooth user experience. It aligns with previous decisions to enhance visual elements and user interactions, such as the addition of a dark/light preview background toggle and language-aware visualizations. Thank you for your contributions, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title fix: streak user parameter validation and error SVGs Fix User Parameter Validation and SVG Error Handling Aug 14, 2026
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Aug 14, 2026
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/3952-[hash].js 7.84 KB 7.80 KB +0.04 KB (+0.54%) 🔴 Regression

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 5005.27 KB 5005.04 KB +0.22 KB (+0.00%)
Total CSS 354.80 KB 354.80 KB 0 B

@Aamod007 Aamod007 added mentor:Aamod007 type:bug Something isn't working as expected level:beginner Small changes Usually isolated fixes or simple UI/text updates. labels Aug 16, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error handling and validation fix for JSON responses is good, but your branch is polluted with unrelated commits (like the Docker builds, timezone mocks, and webhook handler changes). Could you please rebase your branch or isolate just the SVG/JSON error handling changes into a clean branch? We can't merge this while it contains unrelated commits from other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: No input validation on user param invalid usernames cause unhandled errors instead of a graceful error SVG

2 participants