Add Unit Tests for GitHub Username Validation - #9030
Conversation
|
@Rakshak05 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR enhances the testing coverage for username validation, which is crucial for maintaining data integrity and user experience. It aligns with previous decisions to improve username normalization across various APIs. Thank you for your contribution! |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Very comprehensive test suite for GitHub username validation! The negative cases are well thought out and perfectly ensure that our security and length validations won't regress. Approved!
|
🎉 Congratulations @Rakshak05! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #8368
Added a dedicated unit test file
lib/validations.github-username.test.tsto provide comprehensive test coverage forvalidateGitHubUsername.Tests cover:
Pillar
Visual Preview
N/A (Unit tests only)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.